ios/chrome/browser/ui/reading_list/offline_page_native_content.mm - Issue 2616633003: Fix crash in StaticHTMLNativeContent when deallocating WKWebView on iOS9

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/reading_list/offline_page_native_content.mm

Issue 2616633003: Fix crash in StaticHTMLNativeContent when deallocating WKWebView on iOS9 (Closed)

Patch Set: setDelegate in dealloc Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/ui/reading_list/offline_page_native_content.mm

diff --git a/ios/chrome/browser/ui/reading_list/offline_page_native_content.mm b/ios/chrome/browser/ui/reading_list/offline_page_native_content.mm

index 7d1945ebd9585d5875e877c1ca11c733a5641880..1d2442330ffb93563eaaabc70ca2a397907ecca0 100644

--- a/ios/chrome/browser/ui/reading_list/offline_page_native_content.mm

+++ b/ios/chrome/browser/ui/reading_list/offline_page_native_content.mm

@@ -92,6 +92,7 @@

- (void)restoreOnlineURL {

web::NavigationItem* item =

_webState->GetNavigationManager()->GetLastCommittedItem();

+ DCHECK(item && item->GetVirtualURL() == [self virtualURL]);

item->SetURL([self virtualURL]);

item->SetVirtualURL([self virtualURL]);

}