First pass at pre-rendering saveLayers for GPU

First pass at pre-rendering saveLayers for GPU

In the interest of getting something that would be potentially useable in M36 here is a version of the pull-layers-forward task that overloads SkPicturePlayback's draw functionality. In an ideal world this would add 2 SkPicturePlayback-derived classes (one to pre-render the layers, one to render the picture using the pre-rendered layers).

[reed1, 2014-05-07 16:13:28]

https://codereview.chromium.org/261663003/diff/120001/src/core/SkPicturePlayb...
File src/core/SkPicturePlayback.h (right):

https://codereview.chromium.org/261663003/diff/120001/src/core/SkPicturePlayb...
src/core/SkPicturePlayback.h:268: class PlaybackReplacements {
nit: can this guy live in the .cpp, and just forward-declare its name here?

[robertphillips, 2014-05-07 16:52:03]

https://codereview.chromium.org/261663003/diff/120001/src/core/SkPicturePlayb...
File src/core/SkPicturePlayback.h (right):

https://codereview.chromium.org/261663003/diff/120001/src/core/SkPicturePlayb...
src/core/SkPicturePlayback.h:268: class PlaybackReplacements {
SkGpuDevice needs access to it. I have, however, moved the non-single-line
methods to the cpp.

[bsalomon, 2014-05-07 17:07:20]

I defer to mike on this CL.

[robertphillips, 2014-05-07 21:25:28]

Received verbal lgtm from Mike R.

[robertphillips, 2014-05-07 21:25:38]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2014-05-07 21:26:49]

CQ is trying da patch. Follow status at

https://skia-tree-status.appspot.com/cq/robertphillips@google.com/261663003/1...

[commit-bot: I haz the power, 2014-05-07 21:26:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-07 21:26:51]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[bsalomon, 2014-05-07 21:28:57]

On 2014/05/07 21:26:51, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer or
> a provisional committer, _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

lgtm

[bsalomon, 2014-05-07 21:29:02]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-05-07 21:29:45]

CQ is trying da patch. Follow status at

https://skia-tree-status.appspot.com/cq/robertphillips@google.com/261663003/1...

[robertphillips, 2014-05-07 21:31:28]

committed as r14632

[commit-bot: I haz the power, 2014-05-07 21:35:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-07 21:35:59]

Failed to apply patch for include/core/SkPicture.h:
While running patch -p0 --forward --force --no-backup-if-mismatch;
  patching file include/core/SkPicture.h
  Hunk #1 FAILED at 477.
  1 out of 1 hunk FAILED -- saving rejects to file include/core/SkPicture.h.rej

Patch:       include/core/SkPicture.h
Index: include/core/SkPicture.h
===================================================================
--- include/core/SkPicture.h	(revision 14614)
+++ include/core/SkPicture.h	(working copy)
@@ -477,6 +477,7 @@
     friend class SkPicturePlayback;
     friend class SkPictureRecorder;
     friend class SkGpuDevice;
+    friend class GrGatherCanvas;
     friend class GrGatherDevice;
     friend class SkDebugCanvas;