Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2616623006: Convert audiocontext-close-basic and max-contexts to testharness (Closed)

Created:
3 years, 11 months ago by Raymond Toy
Modified:
3 years, 11 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert audiocontext-close-basic and max-contexts to testharness Manually converted test to use testharness and new Audit. BUG=678701 TEST=AudioContext/audiocontext-close-basic.html, audiocontext-max-contexts.html Review-Url: https://codereview.chromium.org/2616623006 Cr-Commit-Position: refs/heads/master@{#445549} Committed: https://chromium.googlesource.com/chromium/src/+/ec77ce738b4415bb5d2bf6aa2779931a06676dfe

Patch Set 1 #

Patch Set 2 : Convert audiocontext-max-contexts too. #

Patch Set 3 : Clean up #

Messages

Total messages: 9 (5 generated)
Raymond Toy
PTAL
3 years, 11 months ago (2017-01-23 19:04:02 UTC) #3
hongchan
lgtm
3 years, 11 months ago (2017-01-23 19:39:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616623006/40001
3 years, 11 months ago (2017-01-23 22:43:57 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 23:56:20 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ec77ce738b4415bb5d2bf6aa2779...

Powered by Google App Engine
This is Rietveld 408576698