Remove CFX_MapPtrToPtr in xfa/fgas, part 2

Remove CFX_MapPtrToPtr in xfa/fgas, part 2

Review-Url: https://codereview.chromium.org/2616623005
Committed: https://pdfium.googlesource.com/pdfium/+/6fd07ef0a817dca5acbcadea41b8f880376f339a

[Tom Sepez, 2017-01-05 21:29:13]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2017-01-05 21:29:14]

Dan, for review.

[Tom Sepez, 2017-01-05 21:30:06]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 21:30:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2017-01-05 21:31:46]

https://codereview.chromium.org/2616623005/diff/1/xfa/fgas/font/cfgas_fontmgr...
File xfa/fgas/font/cfgas_fontmgr.cpp (right):

https://codereview.chromium.org/2616623005/diff/1/xfa/fgas/font/cfgas_fontmgr...
xfa/fgas/font/cfgas_fontmgr.cpp:578: for (auto& pair : m_Hash2CandidateList)
NOTE: hang on, I'm going to make this unique_ptr.

[Tom Sepez, 2017-01-05 21:41:27]

Ok, really ready this time.

[dsinclair, 2017-01-06 02:40:29]

lgtm w/ nits

https://codereview.chromium.org/2616623005/diff/20001/xfa/fgas/font/cfgas_gef...
File xfa/fgas/font/cfgas_gefont.cpp (right):

https://codereview.chromium.org/2616623005/diff/20001/xfa/fgas/font/cfgas_gef...
xfa/fgas/font/cfgas_gefont.cpp:319: CFX_Rect& bbox,
Out param should be *

https://codereview.chromium.org/2616623005/diff/20001/xfa/fgas/font/cfgas_gef...
File xfa/fgas/font/cfgas_gefont.h (right):

https://codereview.chromium.org/2616623005/diff/20001/xfa/fgas/font/cfgas_gef...
xfa/fgas/font/cfgas_gefont.h:112: std::map<FX_WCHAR, CFX_Rect*> m_BBoxMap;
Add comment that the Rect* is owned by m_pRectArray to make ownership clear.

[Tom Sepez, 2017-01-06 17:27:03]

https://codereview.chromium.org/2616623005/diff/20001/xfa/fgas/font/cfgas_gef...
File xfa/fgas/font/cfgas_gefont.cpp (right):

https://codereview.chromium.org/2616623005/diff/20001/xfa/fgas/font/cfgas_gef...
xfa/fgas/font/cfgas_gefont.cpp:319: CFX_Rect& bbox,
On 2017/01/06 02:40:29, dsinclair wrote:
> Out param should be *

Done.

https://codereview.chromium.org/2616623005/diff/20001/xfa/fgas/font/cfgas_gef...
File xfa/fgas/font/cfgas_gefont.h (right):

https://codereview.chromium.org/2616623005/diff/20001/xfa/fgas/font/cfgas_gef...
xfa/fgas/font/cfgas_gefont.h:112: std::map<FX_WCHAR, CFX_Rect*> m_BBoxMap;
On 2017/01/06 02:40:29, dsinclair wrote:
> Add comment that the Rect* is owned by m_pRectArray to make ownership clear.

Done.

[Tom Sepez, 2017-01-06 17:29:24]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2017-01-06 17:29:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
dsinclair@chromium.org
Link to the patchset: https://codereview.chromium.org/2616623005/#ps60001
(title: "typo")

[commit-bot: I haz the power, 2017-01-06 17:29:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 17:48:18]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1483723764511990,
"parent_rev": "8d94b6687f27e1238f352939434704f75b330c1d", "commit_rev":
"6fd07ef0a817dca5acbcadea41b8f880376f339a"}

[commit-bot: I haz the power, 2017-01-06 17:48:21]

Description was changed from

==========
Remove CFX_MapPtrToPtr in xfa/fgas, part 2
==========

to

==========
Remove CFX_MapPtrToPtr in xfa/fgas, part 2

Review-Url: https://codereview.chromium.org/2616623005
Committed:
https://pdfium.googlesource.com/pdfium/+/6fd07ef0a817dca5acbcadea41b8f880376f...
==========

[commit-bot: I haz the power, 2017-01-06 17:48:22]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/6fd07ef0a817dca5acbcadea41b8f880376f...