Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2616613004: Warn about but ignore multiple attempts to create activity-report histogram. (Closed)

Created:
3 years, 11 months ago by bcwhite
Modified:
3 years, 11 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Warn about but ignore multiple attempts to create activity-report histogram. BUG=678040 Review-Url: https://codereview.chromium.org/2616613004 Cr-Commit-Position: refs/heads/master@{#441734} Committed: https://chromium.googlesource.com/chromium/src/+/2805edaba1b852b6ce489a8f88bd8e90e51b73d2

Patch Set 1 #

Patch Set 2 : no warning message #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M base/metrics/histogram_base.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 17 (11 generated)
bcwhite
3 years, 11 months ago (2017-01-05 17:26:01 UTC) #3
Alexei Svitkine (slow)
If it's expected behavior like it is on Android, I don't think it should even ...
3 years, 11 months ago (2017-01-05 17:31:49 UTC) #5
bcwhite
On 2017/01/05 17:31:49, Alexei Svitkine (slow) wrote: > If it's expected behavior like it is ...
3 years, 11 months ago (2017-01-05 18:40:36 UTC) #10
Alexei Svitkine (slow)
lgtm
3 years, 11 months ago (2017-01-05 18:48:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616613004/20001
3 years, 11 months ago (2017-01-05 18:49:27 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-05 19:38:46 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2805edaba1b852b6ce489a8f88bd...

Powered by Google App Engine
This is Rietveld 408576698