Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 2616593002: Move core/animation timers to frame-specific task runners. (Closed)

Created:
3 years, 11 months ago by dcheng
Modified:
3 years, 11 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, Eric Willigers, rjwright, rwlbuis, shans, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move core/animation timers to frame-specific task runners. Some animation events are dispatched on the DOM manipulation task source. However, the spec [1] doesn't seem to say much about timelines and their animations, so dispatch them on the unspeced timer source. [1] https://w3c.github.io/web-animations/#document-timelines BUG=624694 Committed: https://crrev.com/d1f518fa9e5e4b96b5942b90767272377cbadbb7 Cr-Commit-Position: refs/heads/master@{#441306}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M third_party/WebKit/Source/core/animation/AnimationTimeline.h View 3 chunks +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CompositorPendingAnimations.h View 3 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
dcheng
The web animations spec was the closest thing I could find that documents this, and ...
3 years, 11 months ago (2017-01-04 01:25:02 UTC) #2
alancutter (OOO until 2018)
rs lgtm.
3 years, 11 months ago (2017-01-04 02:00:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616593002/1
3 years, 11 months ago (2017-01-04 02:13:14 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 03:18:36 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 03:21:19 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d1f518fa9e5e4b96b5942b90767272377cbadbb7
Cr-Commit-Position: refs/heads/master@{#441306}

Powered by Google App Engine
This is Rietveld 408576698