Fix WebVR support for devices without Async Reprojection.

Fix WebVR support for devices without Async Reprojection.

Adds a java Surface to render into for devices that don't support async reprojection.

BUG=674233
Committed: https://crrev.com/8e41e5abe95bb566b24c84a226a45383abfd2417
Cr-Commit-Position: refs/heads/master@{#441443}

[mthiesse, 2017-01-04 00:41:49]

mthiesse@chromium.org changed reviewers:
+ bshe@chromium.org, klausw@chromium.org

[mthiesse, 2017-01-04 00:41:49]

PTAL

[bshe, 2017-01-04 16:40:24]

lgtm with nits

https://codereview.chromium.org/2616583002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
(right):

https://codereview.chromium.org/2616583002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java:302:
public void surfaceChanged(SurfaceHolder holder, int format, int width, int
height) {
can you add comment on why we dont need to do anything on surfaceChanged and
surfaceDestroyed?

https://codereview.chromium.org/2616583002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2616583002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell.cc:137: gvr_api, for_web_vr,
nit: one parameter per line

https://codereview.chromium.org/2616583002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell_gl.cc (right):

https://codereview.chromium.org/2616583002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_gl.cc:222: CHECK(!ready_to_draw_);
optional nit: rename to gl_initialized_?

https://codereview.chromium.org/2616583002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_gl.cc:295: return;
nit: remove return

[mthiesse, 2017-01-04 16:57:51]

The CQ bit was checked by mthiesse@chromium.org

[mthiesse, 2017-01-04 16:57:52]

The patchset sent to the CQ was uploaded after l-g-t-m from bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/2616583002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2017-01-04 16:58:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mthiesse, 2017-01-04 16:58:09]

https://codereview.chromium.org/2616583002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
(right):

https://codereview.chromium.org/2616583002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java:302:
public void surfaceChanged(SurfaceHolder holder, int format, int width, int
height) {
On 2017/01/04 16:40:23, bshe wrote:
> can you add comment on why we dont need to do anything on surfaceChanged and
> surfaceDestroyed?

Done.

https://codereview.chromium.org/2616583002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell.cc (right):

https://codereview.chromium.org/2616583002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell.cc:137: gvr_api, for_web_vr,
On 2017/01/04 16:40:23, bshe wrote:
> nit: one parameter per line

Done.

https://codereview.chromium.org/2616583002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/vr_shell_gl.cc (right):

https://codereview.chromium.org/2616583002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_gl.cc:222: CHECK(!ready_to_draw_);
On 2017/01/04 16:40:23, bshe wrote:
> optional nit: rename to gl_initialized_?

I think ready_to_draw_ is clearer. GL being initialized doesn't necessarily mean
we're ready to enter our render loop.

https://codereview.chromium.org/2616583002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/vr_shell_gl.cc:295: return;
On 2017/01/04 16:40:23, bshe wrote:
> nit: remove return

Done.

[commit-bot: I haz the power, 2017-01-04 17:40:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 17:40:51]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[mthiesse, 2017-01-04 17:51:55]

The CQ bit was checked by mthiesse@chromium.org

[mthiesse, 2017-01-04 17:51:56]

The patchset sent to the CQ was uploaded after l-g-t-m from bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/2616583002/#ps40001
(title: "Fix compile?")

[commit-bot: I haz the power, 2017-01-04 17:52:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[klausw, 2017-01-04 18:01:29]

On 2017/01/04 17:52:13, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

LGTM

[klausw, 2017-01-04 18:01:30]

On 2017/01/04 17:52:13, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

LGTM

[commit-bot: I haz the power, 2017-01-04 20:08:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1483552315734830,
"parent_rev": "9426c6737ac281cbd552816b7ca365f1cc992e48", "commit_rev":
"1a6ed30256b3e36ee9c2b1bdb9fdff4f8c50d17b"}

[commit-bot: I haz the power, 2017-01-04 20:08:59]

Description was changed from

==========
Fix WebVR support for devices without Async Reprojection.

Adds a java Surface to render into for devices that don't support async
reprojection.

BUG=674233
==========

to

==========
Fix WebVR support for devices without Async Reprojection.

Adds a java Surface to render into for devices that don't support async
reprojection.

BUG=674233

Review-Url: https://codereview.chromium.org/2616583002
==========

[commit-bot: I haz the power, 2017-01-04 20:09:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2017-01-04 20:12:27]

Description was changed from

==========
Fix WebVR support for devices without Async Reprojection.

Adds a java Surface to render into for devices that don't support async
reprojection.

BUG=674233

Review-Url: https://codereview.chromium.org/2616583002
==========

to

==========
Fix WebVR support for devices without Async Reprojection.

Adds a java Surface to render into for devices that don't support async
reprojection.

BUG=674233

Committed: https://crrev.com/8e41e5abe95bb566b24c84a226a45383abfd2417
Cr-Commit-Position: refs/heads/master@{#441443}
==========

[commit-bot: I haz the power, 2017-01-04 20:12:28]

Patchset 3 (id:??) landed as
https://crrev.com/8e41e5abe95bb566b24c84a226a45383abfd2417
Cr-Commit-Position: refs/heads/master@{#441443}