Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2616513002: Make sure pages that are closing but not yet closed are still suspended. (Closed)

Created:
3 years, 11 months ago by dcheng
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Make sure pages that are closing but not yet closed are still suspended. BUG=671102 Review-Url: https://codereview.chromium.org/2580703003 Cr-Commit-Position: refs/heads/master@{#440376} (cherry picked from commit 0879cb1c4d5e7a53d060bfb7cf7cf9ea05aced72) Committed: https://chromium.googlesource.com/chromium/src/+/dc3f2823c1485ab302a2144ec1fcfe37f0e5af50

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -32 lines) Patch
M third_party/WebKit/Source/core/frame/DOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/FrameTree.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/Page.h View 6 chunks +21 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 3 chunks +15 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/page/ScopedPageSuspender.h View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/ScopedPageSuspender.cpp View 2 chunks +10 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/tests/ChromeClientImplTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dcheng
3 years, 11 months ago (2017-01-03 21:51:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dc3f2823c1485ab302a2144ec1fcfe37f0e5af50.

Powered by Google App Engine
This is Rietveld 408576698