Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: third_party/WebKit/Source/core/page/ScopedPageSuspender.cpp

Issue 2616513002: Make sure pages that are closing but not yet closed are still suspended. (Closed)
Patch Set: Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/ScopedPageSuspender.cpp
diff --git a/third_party/WebKit/Source/core/page/ScopedPageSuspender.cpp b/third_party/WebKit/Source/core/page/ScopedPageSuspender.cpp
index f03dd2431bce5e98dcfc2eee8b126cf0bf743081..f169e32ae5752af58fa457db000077ea95e571ee 100644
--- a/third_party/WebKit/Source/core/page/ScopedPageSuspender.cpp
+++ b/third_party/WebKit/Source/core/page/ScopedPageSuspender.cpp
@@ -35,15 +35,6 @@ namespace {
unsigned s_suspensionCount = 0;
-void setSuspended(bool isSuspended) {
- // Make a copy of the collection. Undeferring loads can cause script to run,
- // which would mutate ordinaryPages() in the middle of iteration.
- HeapVector<Member<Page>> pages;
- copyToVector(Page::ordinaryPages(), pages);
- for (const auto& page : pages)
- page->setSuspended(isSuspended);
-}
-
} // namespace
ScopedPageSuspender::ScopedPageSuspender() {
@@ -62,6 +53,16 @@ ScopedPageSuspender::~ScopedPageSuspender() {
Platform::current()->currentThread()->scheduler()->resumeTimerQueue();
}
+void ScopedPageSuspender::setSuspended(bool isSuspended) {
+ // Make a copy of the collection. Undeferring loads can cause script to run,
+ // which would mutate ordinaryPages() in the middle of iteration.
+ HeapVector<Member<Page>> pages;
+ copyToVector(Page::ordinaryPages(), pages);
+
+ for (const auto& page : pages)
+ page->setSuspended(isSuspended);
+}
+
bool ScopedPageSuspender::isActive() {
return s_suspensionCount > 0;
}
« no previous file with comments | « third_party/WebKit/Source/core/page/ScopedPageSuspender.h ('k') | third_party/WebKit/Source/web/ChromeClientImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698