Support all drawable types in DropdownItem.

Support all drawable types in DropdownItem.

No need to hardcode to vector as that exposes more implementation
details that needed.  It can easily support all types.

BUG=

Committed: https://crrev.com/b923094a750a2f76448d4a7ccf0779725e5be74a
Cr-Commit-Position: refs/heads/master@{#441278}

[Ted C, 2017-01-03 21:43:38]

tedchoc@chromium.org changed reviewers:
+ csashi@google.com, dtrainor@chromium.org

[Ted C, 2017-01-03 21:43:38]

PTAL

[csashi, 2017-01-03 22:20:35]

lgtm

LG. Thanks for fixing this. May I suggest checking with ianwen? Ian recommended
the VectorDrawableCompat call.

[Ted C, 2017-01-03 22:23:46]

tedchoc@chromium.org changed reviewers:
+ ianwen@chromium.org

[Ted C, 2017-01-03 22:23:46]

+ianwen - for switching to AppCompatResources

[Ian Wen, 2017-01-03 22:33:02]

lgtm!

https://codereview.chromium.org/2616503002/diff/1/ui/android/java/src/org/chr...
File ui/android/java/src/org/chromium/ui/DropdownAdapter.java (right):

https://codereview.chromium.org/2616503002/diff/1/ui/android/java/src/org/chr...
ui/android/java/src/org/chromium/ui/DropdownAdapter.java:179:
iconView.setImageDrawable(AppCompatResources.getDrawable(mContext,
item.getIconId()));
Aha! This was the function that I was trying to find. Good catch!

[David Trainor- moved to gerrit, 2017-01-03 23:10:09]

lgtm

[Ted C, 2017-01-03 23:11:01]

The CQ bit was checked by tedchoc@chromium.org

[commit-bot: I haz the power, 2017-01-03 23:11:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-03 23:47:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-03 23:47:35]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Ted C, 2017-01-04 00:46:24]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2017-01-04 00:46:25]

The patchset sent to the CQ was uploaded after l-g-t-m from csashi@google.com,
ianwen@chromium.org, dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2616503002/#ps20001
(title: "Fix AutofillKeyboardAccessory")

[commit-bot: I haz the power, 2017-01-04 00:47:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 01:21:53]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483490784807330,
"parent_rev": "769c3624debb561d2da058955a8b18262be2d77b", "commit_rev":
"5d31036aa28cd5b17eba4d31f48788efbf0da24d"}

[commit-bot: I haz the power, 2017-01-04 01:22:40]

Description was changed from

==========
Support all drawable types in DropdownItem.

No need to hardcode to vector as that exposes more implementation
details that needed.  It can easily support all types.

BUG=
==========

to

==========
Support all drawable types in DropdownItem.

No need to hardcode to vector as that exposes more implementation
details that needed.  It can easily support all types.

BUG=

Review-Url: https://codereview.chromium.org/2616503002
==========

[commit-bot: I haz the power, 2017-01-04 01:22:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2017-01-04 01:26:33]

Description was changed from

==========
Support all drawable types in DropdownItem.

No need to hardcode to vector as that exposes more implementation
details that needed.  It can easily support all types.

BUG=

Review-Url: https://codereview.chromium.org/2616503002
==========

to

==========
Support all drawable types in DropdownItem.

No need to hardcode to vector as that exposes more implementation
details that needed.  It can easily support all types.

BUG=

Committed: https://crrev.com/b923094a750a2f76448d4a7ccf0779725e5be74a
Cr-Commit-Position: refs/heads/master@{#441278}
==========

[commit-bot: I haz the power, 2017-01-04 01:26:34]

Patchset 2 (id:??) landed as
https://crrev.com/b923094a750a2f76448d4a7ccf0779725e5be74a
Cr-Commit-Position: refs/heads/master@{#441278}