Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2616443002: bluetooth: web: IDL fixes: Inherit EventTarget, SameObject navigator.bluetooth (Closed)

Created:
3 years, 11 months ago by scheib
Modified:
3 years, 11 months ago
Reviewers:
foolip
CC:
chromium-reviews, blink-reviews, haraken, scheib+watch_chromium.org, ortuno+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: web: IDL fixes: Inherit EventTarget, SameObject navigator.bluetooth These changes reflect the IDL update made in the spec: https://github.com/WebBluetoothCG/web-bluetooth/commit/8d5ed3939d906e8874e12d8a5d94f99960f9e520 EventTarget is not a mixin, and so 'Implements' should not be used, instead bluetooth should inherit from EventTarget. Also, navigator.bluetooth should use [SameObject]. Review-Url: https://codereview.chromium.org/2616443002 Cr-Commit-Position: refs/heads/master@{#445306} Committed: https://chromium.googlesource.com/chromium/src/+/09b5874dabf7b3c7cbf4a1e8a0af6ba0d40b68fc

Patch Set 1 #

Patch Set 2 : WIP #

Patch Set 3 : WIP #

Patch Set 4 : Merge TOT #

Patch Set 5 : Merge TOT #

Patch Set 6 : merge TOT #

Patch Set 7 : fixeup merge TOT #

Messages

Total messages: 37 (32 generated)
scheib
3 years, 11 months ago (2017-01-03 19:16:09 UTC) #4
foolip
IDL changes LGTM, but are events ever dispatch on Bluetooth instances? If they were already, ...
3 years, 11 months ago (2017-01-21 13:00:55 UTC) #31
scheib
No events currently to Bluetooth instances.
3 years, 11 months ago (2017-01-22 22:43:44 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616443002/120001
3 years, 11 months ago (2017-01-22 22:43:59 UTC) #34
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 00:28:55 UTC) #37
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/09b5874dabf7b3c7cbf4a1e8a0af...

Powered by Google App Engine
This is Rietveld 408576698