Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2616423002: Added IsPublicSession utility function to profiles_state (Closed)

Created:
3 years, 11 months ago by Ivan Šandrk
Modified:
3 years, 11 months ago
Reviewers:
anthonyvd
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Missing full stop in comment #

Patch Set 3 : Moved to profiles_state #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M chrome/browser/profiles/profiles_state.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profiles_state.cc View 1 2 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Ivan Šandrk
Hey Anthony ptal! Thanks, Ivan
3 years, 11 months ago (2017-01-09 15:24:24 UTC) #6
anthonyvd
Hi Ivan, This seems a little out of place in Profile, especially as a static ...
3 years, 11 months ago (2017-01-09 15:47:02 UTC) #7
Ivan Šandrk
On 2017/01/09 15:47:02, anthonyvd wrote: > Hi Ivan, > > This seems a little out ...
3 years, 11 months ago (2017-01-09 16:05:25 UTC) #11
anthonyvd
lgtm
3 years, 11 months ago (2017-01-09 16:31:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616423002/40001
3 years, 11 months ago (2017-01-09 16:34:26 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 16:50:37 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0af058d7d4b9312ce34b674316ea...

Powered by Google App Engine
This is Rietveld 408576698