Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2616403007: X87: [FeedbackVector] Infrastructure for literal arrays in the vector. (Closed)

Created:
3 years, 11 months ago by zhengxing.li
Modified:
3 years, 11 months ago
Reviewers:
mvstanton, chunyang.dai
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [FeedbackVector] Infrastructure for literal arrays in the vector. port 38602f1ff553b32815d34a05cd6d965f4fc20960 (r42146) original commit message: This changes the NewClosure interface descriptor, but ignores the additional vector/slot arguments for now. The feedback vector gets larger, as it holds a space for each literal array. A follow-on CL will constructively use this space. BUG= Review-Url: https://codereview.chromium.org/2616403007 Cr-Commit-Position: refs/heads/master@{#42157} Committed: https://chromium.googlesource.com/v8/v8/+/0dde3045ad78d69ae63499256233e31849ecfd94

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/x87/interface-descriptors-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
zhengxing.li
PTAL, thanks!
3 years, 11 months ago (2017-01-10 03:42:02 UTC) #2
chunyang.dai
On 2017/01/10 03:42:02, zhengxing.li wrote: > PTAL, thanks! LGTM. thanks
3 years, 11 months ago (2017-01-10 03:44:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616403007/1
3 years, 11 months ago (2017-01-10 03:45:02 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 04:04:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0dde3045ad78d69ae63499256233e31849e...

Powered by Google App Engine
This is Rietveld 408576698