DevTools: Add types to all properties on SplitWidget

DevTools: Add types to all properties on SplitWidget

BUG=none

Review-Url: https://codereview.chromium.org/2616403005
Cr-Commit-Position: refs/heads/master@{#443354}
Committed: https://chromium.googlesource.com/chromium/src/+/e09f6f26f363fd98d8a7a8e37ba4c0c71aa4ef63

[einbinder, 2017-01-09 19:31:18]

einbinder@chromium.org changed reviewers:
+ dgozman@chromium.org

[einbinder, 2017-01-09 19:31:18]

ptal

[einbinder, 2017-01-09 19:31:21]

The CQ bit was checked by einbinder@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-09 19:32:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2017-01-09 19:33:48]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2017-01-09 19:33:49]

How do we not regress it?

[einbinder, 2017-01-09 19:43:44]

On 2017/01/09 at 19:33:49, pfeldman wrote:
> How do we not regress it?

I will remove @unrestricted, but I first need to fix all the subclasses.

[commit-bot: I haz the power, 2017-01-09 21:23:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-09 21:23:16]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pfeldman, 2017-01-09 23:23:59]

lgtm

[einbinder, 2017-01-12 18:11:18]

https://codereview.chromium.org/2616403005/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/inspector/components/minimum-size.html
(left):

https://codereview.chromium.org/2616403005/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/components/minimum-size.html:84:
childsplitWidget.setSidebarWidget(null);
setSidebarWidget takes a non-null Widget. This was suppressing invalidate
constraints, which changes the results slightly. I'm not sure if that was
intentional for the test.

[einbinder, 2017-01-12 18:57:05]

The CQ bit was checked by einbinder@chromium.org

[einbinder, 2017-01-12 18:57:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2616403005/#ps40001
(title: "Invalidate constraints on detach")

[commit-bot: I haz the power, 2017-01-12 18:57:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 20:51:01]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484247425962150,
"parent_rev": "2c8eed34518aa37ebe2decc78af0694e1826c43b", "commit_rev":
"e09f6f26f363fd98d8a7a8e37ba4c0c71aa4ef63"}

[commit-bot: I haz the power, 2017-01-12 20:51:32]

Description was changed from

==========
DevTools: Add types to all properties on SplitWidget

BUG=none
==========

to

==========
DevTools: Add types to all properties on SplitWidget

BUG=none

Review-Url: https://codereview.chromium.org/2616403005
Cr-Commit-Position: refs/heads/master@{#443354}
Committed:
https://chromium.googlesource.com/chromium/src/+/e09f6f26f363fd98d8a7a8e37ba4...
==========

[commit-bot: I haz the power, 2017-01-12 20:51:34]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e09f6f26f363fd98d8a7a8e37ba4...