Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1336)

Issue 2616403004: [WPT Export] Add proper author to exported commits (Closed)

Created:
3 years, 11 months ago by jeffcarp
Modified:
3 years, 11 months ago
Reviewers:
qyearsley
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WPT Export] Add proper author to exported commits BUG=673814 R=qyearsley@chromium.org Review-Url: https://codereview.chromium.org/2616403004 Cr-Commit-Position: refs/heads/master@{#442636} Committed: https://chromium.googlesource.com/chromium/src/+/bc0eecbb3bca9a35b72e4dc926a7cfc635b9ef7a

Patch Set 1 #

Patch Set 2 : [WPT Export] Add proper author to exported commits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/chromium_commit.py View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/local_wpt_unittest.py View 1 1 chunk +12 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_exporter.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
jeffcarp
3 years, 11 months ago (2017-01-09 19:16:30 UTC) #1
qyearsley
lgtm The author string is a name and email address (often a @chromium.org), right? It's ...
3 years, 11 months ago (2017-01-09 19:36:17 UTC) #2
jeffcarp
On 2017/01/09 at 19:36:17, qyearsley wrote: > lgtm > > The author string is a ...
3 years, 11 months ago (2017-01-10 17:15:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616403004/20001
3 years, 11 months ago (2017-01-10 17:15:43 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 18:33:43 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/bc0eecbb3bca9a35b72e4dc926a7...

Powered by Google App Engine
This is Rietveld 408576698