|
|
Revert of Add more WebVR layout tests, adjust test format (patchset #4 id:60001 of https://codereview.chromium.org/2617183002/ )
Reason for revert:
Two of the added tests crash:
vr/requestAnimationFrame_invalidhandle.html
vr/requestAnimationFrame_unregister.html
BUG= 679288
Original issue's description:
> Add more WebVR layout tests, adjust test format
>
> Adds a handful of new WebVR layout tests using mocking.
>
> Adjusts the vr_test to pass the provided function an async_test handle. This
> was done due to how easy it was for the previous promise_test implementation
> to resolve earlier than expected, causing the test to pass before all code was
> run with no visible difference in the output. The use of the async_test makes
> the tests slightly more verbose, but ensures that we're only ending the test
> when we expect to.
>
> Add a fix for VRDisplay not initializing layer bounds to defaults correctly.
>
> BUG= 675325, 670490, 650703
>
> Review-Url: https://codereview.chromium.org/2617183002
> Cr-Commit-Position: refs/heads/master@{#442135}
> Committed: https://chromium.googlesource.com/chromium/src/+/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41
TBR=bajones@chromium.org,dglazkov@chromium.org,bsheedy@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 675325, 670490, 650703
Review-Url: https://codereview.chromium.org/2616403002
Cr-Commit-Position: refs/heads/master@{#442237}
Committed: https://chromium.googlesource.com/chromium/src/+/161af0077dffbdd6aa5846677da04c4e3d3d6677
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+284 lines, -906 lines) |
Patch |
 |
D |
third_party/WebKit/LayoutTests/vr/exitPresent_reject_notpresenting.html
|
View
|
|
1 chunk |
+0 lines, -38 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/vr/exitPresent_resolve.html
|
View
|
|
1 chunk |
+0 lines, -48 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/vr/getEyeParameters_match.html
|
View
|
|
1 chunk |
+0 lines, -55 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/vr/getLayers_notpresenting.html
|
View
|
|
1 chunk |
+0 lines, -48 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/vr/getLayers_presenting.html
|
View
|
|
1 chunk |
+0 lines, -58 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/vr/getVRDisplays_one_display.html
|
View
|
|
1 chunk |
+8 lines, -20 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/vr/getVRDisplays_two_display.html
|
View
|
|
1 chunk |
+12 lines, -39 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/vr/getVRDisplays_zero_display.html
|
View
|
|
1 chunk |
+5 lines, -14 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/vr/requestAnimationFrame_called.html
|
View
|
|
1 chunk |
+0 lines, -28 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/vr/requestAnimationFrame_invalidhandle.html
|
View
|
|
1 chunk |
+0 lines, -47 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/vr/requestAnimationFrame_unregister.html
|
View
|
|
1 chunk |
+0 lines, -42 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/vr/requestPresent_reject_badleftbounds.html
|
View
|
|
1 chunk |
+23 lines, -27 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/vr/requestPresent_reject_badrightbounds.html
|
View
|
|
1 chunk |
+23 lines, -27 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/vr/requestPresent_reject_nogesture.html
|
View
|
|
1 chunk |
+11 lines, -16 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/vr/requestPresent_reject_nolayers.html
|
View
|
|
1 chunk |
+20 lines, -23 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/vr/requestPresent_reject_nosource.html
|
View
|
|
1 chunk |
+20 lines, -23 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/vr/requestPresent_reject_notsupported.html
|
View
|
|
1 chunk |
+20 lines, -23 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/vr/requestPresent_reject_nowebgl.html
|
View
|
|
1 chunk |
+22 lines, -25 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/vr/requestPresent_reject_nullsource.html
|
View
|
|
1 chunk |
+0 lines, -38 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/vr/requestPresent_reject_toomanylayers.html
|
View
|
|
1 chunk |
+25 lines, -28 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/vr/requestPresent_resolve.html
|
View
|
|
1 chunk |
+20 lines, -23 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithgesture.html
|
View
|
|
1 chunk |
+0 lines, -56 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithoutgesture.html
|
View
|
|
1 chunk |
+34 lines, -37 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/vr/requestPresent_resolve_webgl2.html
|
View
|
|
1 chunk |
+24 lines, -27 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/vr/resources/fake-vr-displays.js
|
View
|
|
2 chunks |
+14 lines, -40 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/LayoutTests/vr/resources/mock-vr-service.js
|
View
|
|
1 chunk |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/vr/resources/test-constants.js
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
D |
third_party/WebKit/LayoutTests/vr/stageParameters_match.html
|
View
|
|
1 chunk |
+0 lines, -47 lines |
0 comments
|
Download
|
 |
M |
third_party/WebKit/Source/modules/vr/VRDisplay.cpp
|
View
|
|
2 chunks |
+0 lines, -2 lines |
0 comments
|
Download
|
Total messages: 6 (3 generated)
|