Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2616403002: Revert of Add more WebVR layout tests, adjust test format (Closed)

Created:
3 years, 11 months ago by vitaliii
Modified:
3 years, 11 months ago
Reviewers:
bsheedy, bajones, dglazkov
CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, haraken, feature-vr-reviews_chromium.org, darktears, blink-reviews, Eric Willigers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add more WebVR layout tests, adjust test format (patchset #4 id:60001 of https://codereview.chromium.org/2617183002/ ) Reason for revert: Two of the added tests crash: vr/requestAnimationFrame_invalidhandle.html vr/requestAnimationFrame_unregister.html BUG=679288 Original issue's description: > Add more WebVR layout tests, adjust test format > > Adds a handful of new WebVR layout tests using mocking. > > Adjusts the vr_test to pass the provided function an async_test handle. This > was done due to how easy it was for the previous promise_test implementation > to resolve earlier than expected, causing the test to pass before all code was > run with no visible difference in the output. The use of the async_test makes > the tests slightly more verbose, but ensures that we're only ending the test > when we expect to. > > Add a fix for VRDisplay not initializing layer bounds to defaults correctly. > > BUG=675325, 670490, 650703 > > Review-Url: https://codereview.chromium.org/2617183002 > Cr-Commit-Position: refs/heads/master@{#442135} > Committed: https://chromium.googlesource.com/chromium/src/+/ed03ff2faec8339e93a7c48ef5213d4d73fc4f41 TBR=bajones@chromium.org,dglazkov@chromium.org,bsheedy@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=675325, 670490, 650703 Review-Url: https://codereview.chromium.org/2616403002 Cr-Commit-Position: refs/heads/master@{#442237} Committed: https://chromium.googlesource.com/chromium/src/+/161af0077dffbdd6aa5846677da04c4e3d3d6677

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -906 lines) Patch
D third_party/WebKit/LayoutTests/vr/exitPresent_reject_notpresenting.html View 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/WebKit/LayoutTests/vr/exitPresent_resolve.html View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/vr/getEyeParameters_match.html View 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/WebKit/LayoutTests/vr/getLayers_notpresenting.html View 1 chunk +0 lines, -48 lines 0 comments Download
D third_party/WebKit/LayoutTests/vr/getLayers_presenting.html View 1 chunk +0 lines, -58 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/getVRDisplays_one_display.html View 1 chunk +8 lines, -20 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/getVRDisplays_two_display.html View 1 chunk +12 lines, -39 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/getVRDisplays_zero_display.html View 1 chunk +5 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/vr/requestAnimationFrame_called.html View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/vr/requestAnimationFrame_invalidhandle.html View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/WebKit/LayoutTests/vr/requestAnimationFrame_unregister.html View 1 chunk +0 lines, -42 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/requestPresent_reject_badleftbounds.html View 1 chunk +23 lines, -27 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/requestPresent_reject_badrightbounds.html View 1 chunk +23 lines, -27 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/requestPresent_reject_nogesture.html View 1 chunk +11 lines, -16 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/requestPresent_reject_nolayers.html View 1 chunk +20 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/requestPresent_reject_nosource.html View 1 chunk +20 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/requestPresent_reject_notsupported.html View 1 chunk +20 lines, -23 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/requestPresent_reject_nowebgl.html View 1 chunk +22 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/vr/requestPresent_reject_nullsource.html View 1 chunk +0 lines, -38 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/requestPresent_reject_toomanylayers.html View 1 chunk +25 lines, -28 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/requestPresent_resolve.html View 1 chunk +20 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithgesture.html View 1 chunk +0 lines, -56 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/requestPresent_resolve_repeatwithoutgesture.html View 1 chunk +34 lines, -37 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/requestPresent_resolve_webgl2.html View 1 chunk +24 lines, -27 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/resources/fake-vr-displays.js View 2 chunks +14 lines, -40 lines 0 comments Download
M third_party/WebKit/LayoutTests/vr/resources/mock-vr-service.js View 1 chunk +3 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/vr/resources/test-constants.js View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/vr/stageParameters_match.html View 1 chunk +0 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
vitaliii
Created Revert of Add more WebVR layout tests, adjust test format
3 years, 11 months ago (2017-01-09 10:58:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616403002/1
3 years, 11 months ago (2017-01-09 10:58:54 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 12:16:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/161af0077dffbdd6aa5846677da0...

Powered by Google App Engine
This is Rietveld 408576698