Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2616393002: PreParsing inner funcs: make scope analysis even more complete. (Closed)

Created:
3 years, 11 months ago by marja
Modified:
3 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PreParsing inner funcs: make scope analysis even more complete. This adds tracking the following: - Let / var declarations in for loops BUG=v8:5501, v8:5516 Review-Url: https://codereview.chromium.org/2616393002 Cr-Commit-Position: refs/heads/master@{#42169} Committed: https://chromium.googlesource.com/v8/v8/+/b23377620893d29c0b2be944e035ce85358e11f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M src/parsing/preparser.h View 1 chunk +5 lines, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +12 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
marja
ptal
3 years, 11 months ago (2017-01-09 10:29:35 UTC) #2
Toon Verwaest
lgtm
3 years, 11 months ago (2017-01-10 10:47:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616393002/1
3 years, 11 months ago (2017-01-10 10:48:41 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 11:15:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/b23377620893d29c0b2be944e035ce85358...

Powered by Google App Engine
This is Rietveld 408576698