Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 2616373002: Add eventlog_provider.dll.pdb to the archive of symbol files. (Closed)

Created:
3 years, 11 months ago by pastarmovj
Modified:
3 years, 11 months ago
Reviewers:
brucedawson
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add eventlog_provider.dll.pdb to the archive of symbol files. Although eventlog_provider.dll is resource only dll archiving the pdb file together with the rest of Chrome will allow for better tracing of the version of the source code used to build the dll shall this ever be needed for issue investigations. BUG=677226 TEST=Builds fine on all builders. Review-Url: https://codereview.chromium.org/2616373002 Cr-Commit-Position: refs/heads/master@{#442534} Committed: https://chromium.googlesource.com/chromium/src/+/7e68269619bfa96b659d0b34310ad77aea857ce0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/tools/build/win/FILES.cfg View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
pastarmovj
Hi Bruce, please review this small CL. Best, Julian
3 years, 11 months ago (2017-01-09 08:59:59 UTC) #2
brucedawson
Thanks - lgtm.
3 years, 11 months ago (2017-01-09 18:56:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616373002/1
3 years, 11 months ago (2017-01-10 08:31:43 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 08:47:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7e68269619bfa96b659d0b34310a...

Powered by Google App Engine
This is Rietveld 408576698