Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2616343006: Revert of Add blink_perf.paint_spinvalidation and blink_perf.svg_spinvalidation suites (Closed)

Created:
3 years, 11 months ago by Xianzhu
Modified:
3 years, 11 months ago
Reviewers:
Zhen Wang, pdr.
CC:
chromium-reviews, telemetry-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add blink_perf.paint_spinvalidation and blink_perf.svg_spinvalidation suites (patchset #2 id:20001 of https://codereview.chromium.org/2557483002/ ) Reason for revert: We've enabled SlimmingPaintInvalidation for experimental which also enabled it for perf tests, so no longer need the separate suites. Original issue's description: > Add blink_perf.paint_spinvalidation and blink_perf.svg_spinvalidation suites > > BUG=646176 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq > > Committed: https://crrev.com/28340254faacae55d9c14a9ac94efd57d6f79748 > Cr-Commit-Position: refs/heads/master@{#436820} TBR=pdr@chromium.org,zhenw@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=646176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq NOTRY=true (added when the CL had passed all CQ bots. There seemed repeated jobs) Review-Url: https://codereview.chromium.org/2616343006 Cr-Commit-Position: refs/heads/master@{#442494} Committed: https://chromium.googlesource.com/chromium/src/+/1d82650f0de664101fd128cdbf9cd7b0f4faf85e

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M tools/perf/benchmarks/blink_perf.py View 1 3 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
Xianzhu
Created Revert of Add blink_perf.paint_spinvalidation and blink_perf.svg_spinvalidation suites
3 years, 11 months ago (2017-01-09 23:23:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616343006/40001
3 years, 11 months ago (2017-01-09 23:27:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL) mac_retina_perf_cq on ...
3 years, 11 months ago (2017-01-10 01:30:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616343006/40001
3 years, 11 months ago (2017-01-10 01:33:18 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_perf_cq on master.tryserver.chromium.perf (JOB_TIMED_OUT, no build URL)
3 years, 11 months ago (2017-01-10 03:35:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616343006/40001
3 years, 11 months ago (2017-01-10 03:36:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616343006/40001
3 years, 11 months ago (2017-01-10 05:10:27 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:40001) as https://chromium.googlesource.com/chromium/src/+/1d82650f0de664101fd128cdbf9cd7b0f4faf85e
3 years, 11 months ago (2017-01-10 05:20:59 UTC) #21
Timothy Loh
On 2017/01/10 05:20:59, commit-bot: I haz the power wrote: > Committed patchset #2 (id:40001) as ...
3 years, 11 months ago (2017-01-11 01:54:29 UTC) #22
Xianzhu
3 years, 11 months ago (2017-01-11 02:16:06 UTC) #23
Message was sent while issue was closed.
On 2017/01/11 01:54:29, Timothy Loh wrote:
> On 2017/01/10 05:20:59, commit-bot: I haz the power wrote:
> > Committed patchset #2 (id:40001) as
> >
>
https://chromium.googlesource.com/chromium/src/+/1d82650f0de664101fd128cdbf9c...
> 
> I think you need to update chromium.perf.fyi.json to no longer reference these
> perf suites as it looks to be causing some failures on the perf bots.
> 
> https://build.chromium.org/p/chromium.perf/builders/Mac%2010.11%20Perf

Thanks for the notice. https://codereview.chromium.org/2624963002/ will fix it.

Powered by Google App Engine
This is Rietveld 408576698