Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 2616303002: treapstore: Add Collection.VisitItemsAscend. (Closed)

Created:
3 years, 11 months ago by dnj
Modified:
3 years, 11 months ago
Reviewers:
Vadim Sh., iannucci
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, maruel+w_chromium.org, tandrii+luci-go_chromium.org
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

treapstore: Add Collection.VisitItemsAscend. This offers an optimal, but unfortunately callback-based, traversal of the collection. BUG=chromium:675485 TEST=unit Review-Url: https://codereview.chromium.org/2616303002 Committed: https://github.com/luci/luci-go/commit/647d8243b192c5a603b4befc3cf524f716003b95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -4 lines) Patch
M common/data/treapstore/store.go View 1 chunk +13 lines, -2 lines 0 comments Download
M common/data/treapstore/store_test.go View 4 chunks +36 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dnj
PTAL
3 years, 11 months ago (2017-01-08 03:38:37 UTC) #2
iannucci
lgtm
3 years, 11 months ago (2017-01-08 05:12:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616303002/1
3 years, 11 months ago (2017-01-08 19:10:30 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-08 19:15:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/647d8243b192c5a603b4befc3cf524f716003b95

Powered by Google App Engine
This is Rietveld 408576698