Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2616223002: arc: Use ARC_GET_INSTANCE_FOR_METHOD for getting file_system instance (Closed)

Created:
3 years, 11 months ago by Yusuke Sato
Modified:
3 years, 11 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tzik, hidehiko+watch_chromium.org, nhiroki, lhchavez+watch_chromium.org, oshima+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Use ARC_GET_INSTANCE_FOR_METHOD for getting file_system instance This is safer than manually specifying min versions. BUG=649782 TEST=git try Review-Url: https://codereview.chromium.org/2616223002 Cr-Commit-Position: refs/heads/master@{#442296} Committed: https://chromium.googlesource.com/chromium/src/+/1411eb8bc047a30d081180b8c30ccdf5124ddfc5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -30 lines) Patch
M chrome/browser/chromeos/arc/fileapi/arc_file_system_instance_util.cc View 6 chunks +12 lines, -30 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Yusuke Sato
PTAL too
3 years, 11 months ago (2017-01-07 01:01:02 UTC) #4
Luis Héctor Chávez
lgtm
3 years, 11 months ago (2017-01-09 17:23:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616223002/1
3 years, 11 months ago (2017-01-09 17:43:09 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-09 18:22:45 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1411eb8bc047a30d081180b8c30c...

Powered by Google App Engine
This is Rietveld 408576698