Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: tools/clang/rewrite_to_chrome_style/tests/constants-original.cc

Issue 2616213003: Get more consistent decisions if a statement is constant in templates (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/rewrite_to_chrome_style/tests/constants-original.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/constants-original.cc b/tools/clang/rewrite_to_chrome_style/tests/constants-original.cc
index 51ce017823e0e59f29486e025347aa25c2154f8f..fe254950e6a1cd79cf3aa9a291901f1b83e1c258 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/constants-original.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/constants-original.cc
@@ -33,8 +33,8 @@ class C {
const int kFunctionConstantFromExpression = 4 + 6;
const int kFunctionConstantFromOtherConsts =
kFunctionConstant + kFunctionConstantFromExpression;
- // These don't do the right thing right now, but names like this don't
- // exist in blink (hopefully).
+ // These are constants but they are hacker_case, so we just leave them as
+ // is since the author explicitly did this.
const int should_be_renamed_to_a_const = 9 - 2;
const int should_also_be_renamed_to_a_const =
kFunctionConstant + kFunctionConstantFromOtherConsts;

Powered by Google App Engine
This is Rietveld 408576698