Get more consistent decisions if a statement is constant in templates

tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc

Index: tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc
diff --git a/tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc b/tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc
index 3f55421bb4356a33149b2f4e24db8e3399384f21..d52c6c1bb1cbc143b1c6a8b1d8f01461a6034f31 100644
--- a/tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc
+++ b/tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc
@@ -33,10 +33,10 @@ class C {
     const int kFunctionConstantFromExpression = 4 + 6;
     const int kFunctionConstantFromOtherConsts =
         kFunctionConstant + kFunctionConstantFromExpression;
-    // These don't do the right thing right now, but names like this don't
-    // exist in blink (hopefully).
-    const int kShould_be_renamed_to_a_const = 9 - 2;
-    const int kShould_also_be_renamed_to_a_const =
+    // These are constants but they are hacker_case, so we just leave them as
+    // is since the author explicitly did this.
+    const int should_be_renamed_to_a_const = 9 - 2;

[dcheng, 2017/01/07 00:45:49]

maybe the prefix should be should_not_ now?

[danakj, 2017/01/07 00:48:00]

Done.

+    const int should_also_be_renamed_to_a_const =
         kFunctionConstant + kFunctionConstantFromOtherConsts;
     const int not_compile_time_const = kFunctionConstant + Function();
   }