Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 2616123002: Prefix BrowserPluginDelegate methods. (Closed)

Created:
3 years, 11 months ago by nasko
Modified:
3 years, 11 months ago
Reviewers:
lazyboy, lfg
CC:
chromium-reviews, jam, darin-cc_chromium.org, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prefix BrowserPluginDelegate methods. This CL prefixes the DidFinishLoading and DidReceiveData methods in BrowserPluginDelegate, so they don't conflict with the WebAssociatedURLLoaderClient versions which currently start with lowercase letter. As part of the Blink rewrite to match Chromium style, those will be colliding in MimeHandlerViewContainer. BUG=582312 Review-Url: https://codereview.chromium.org/2616123002 Cr-Commit-Position: refs/heads/master@{#441994} Committed: https://chromium.googlesource.com/chromium/src/+/a8ac477c3ad2abf257520f22bda13163a763f15d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M content/public/renderer/browser_plugin_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
nasko
Hey guys, Can one of you review this CL for me? It is a prep ...
3 years, 11 months ago (2017-01-06 18:07:12 UTC) #4
lfg
lgtm
3 years, 11 months ago (2017-01-06 18:31:18 UTC) #5
lazyboy
lgtm
3 years, 11 months ago (2017-01-06 18:31:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2616123002/1
3 years, 11 months ago (2017-01-06 18:44:26 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 18:50:24 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a8ac477c3ad2abf257520f22bda1...

Powered by Google App Engine
This is Rietveld 408576698