MD Settings: push policy control indicators to right for checkboxes -> toggles transition

MD Settings: push policy control indicators to right for checkboxes -> toggles transition

R=dschuyler@chromium.org
BUG=673953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2616043002
Cr-Commit-Position: refs/heads/master@{#442154}
Committed: https://chromium.googlesource.com/chromium/src/+/e7565ba94652c87be04cd80f3722d52b418342df

[Dan Beam, 2017-01-06 02:17:33]

Description was changed from

==========
MD Settings: push policy control indicators to right for checkboxes -> toggles
transition

R=dschuyler@chromium.org
BUG=673953
==========

to

==========
MD Settings: push policy control indicators to right for checkboxes -> toggles
transition

R=dschuyler@chromium.org
BUG=673953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-01-06 02:18:23]

The CQ bit was checked by dbeam@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 02:19:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 03:36:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 03:36:31]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-01-07 00:47:49]

ping

[dschuyler, 2017-01-07 02:23:39]

On 2017/01/07 00:47:49, Dan Beam wrote:
> ping

I don't follow the current description in the CL. IIRC there was an issue with
the policy icon so having the checkbox not take 100% of the width when disabled
is desirable. My guess is that this is superseded by some other fix and can be
safely removed. Changing the description or replying here is cool. I'd just like
to know more about what it's fixing before LG'ing it.

[Dan Beam, 2017-01-07 02:36:40]

On 2017/01/07 02:23:39, dschuyler wrote:
> On 2017/01/07 00:47:49, Dan Beam wrote:
> > ping
> 
> I don't follow the current description in the CL. IIRC there was an issue with
> the policy icon so having the checkbox not take 100% of the width when
disabled
> is desirable. My guess is that this is superseded by some other fix and can be
> safely removed. Changing the description or replying here is cool. I'd just
like
> to know more about what it's fixing before LG'ing it.

previously, we wanted power plants to show up at the end of text

[x] Report metrics 🏭

But now we want it at the end for toggles

Report metrics                   🏭 =o

[Dan Beam, 2017-01-07 02:37:41]

On 2017/01/07 02:36:40, Dan Beam wrote:
> On 2017/01/07 02:23:39, dschuyler wrote:
> > On 2017/01/07 00:47:49, Dan Beam wrote:
> > > ping
> > 
> > I don't follow the current description in the CL. IIRC there was an issue
with
> > the policy icon so having the checkbox not take 100% of the width when
> disabled
> > is desirable. My guess is that this is superseded by some other fix and can
be
> > safely removed. Changing the description or replying here is cool. I'd just
> like
> > to know more about what it's fixing before LG'ing it.
> 
> previously, we wanted power plants to show up at the end of text
> 
> [x] Report metrics 🏭
> 
> But now we want it at the end for toggles
> 
> Report metrics                   🏭 =o

Report metrics                   🏭 =o
[x] Report metrics                  🏭

[dschuyler, 2017-01-07 02:51:11]

lgtm

[Dan Beam, 2017-01-07 02:56:41]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2017-01-07 02:56:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-07 04:27:14]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483757801574620, "parent_rev":
"1314396d75b72f1d0676f97fd8d39b59f6bbb3ba", "commit_rev":
"e7565ba94652c87be04cd80f3722d52b418342df"}

[commit-bot: I haz the power, 2017-01-07 04:27:40]

Description was changed from

==========
MD Settings: push policy control indicators to right for checkboxes -> toggles
transition

R=dschuyler@chromium.org
BUG=673953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: push policy control indicators to right for checkboxes -> toggles
transition

R=dschuyler@chromium.org
BUG=673953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2616043002
Cr-Commit-Position: refs/heads/master@{#442154}
Committed:
https://chromium.googlesource.com/chromium/src/+/e7565ba94652c87be04cd80f3722...
==========

[commit-bot: I haz the power, 2017-01-07 04:27:41]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e7565ba94652c87be04cd80f3722...