Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2616023003: [Devtools] Reverse dependency of ResourceTreeModel and NetworkLog (Closed)

Created:
3 years, 11 months ago by allada
Modified:
3 years, 7 months ago
Reviewers:
caseq, dgozman, luoe
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Reverse dependency of ResourceTreeModel and NetworkLog This patch reverses the dependency of NetworkLog depending on ResourceTreeModel to be reversed. This is because ResourceTreeModel does not exist if there is no DOM, but NetworkLog should exist, but with current setup this causes problems with HAR output with service workers because service workers end up without a NetworkLog, but since there's a request they should have a NetworkLog object. R=dgozman_slow,caseq,luoe BUG=668032

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -21 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js View 3 chunks +9 lines, -15 lines 3 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js View 5 chunks +13 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
allada
PTL
3 years, 11 months ago (2017-01-06 01:28:16 UTC) #2
caseq
https://codereview.chromium.org/2616023003/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js File third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js (right): https://codereview.chromium.org/2616023003/diff/1/third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js#newcode112 third_party/WebKit/Source/devtools/front_end/sdk/NetworkLog.js:112: mainFrameNavigated(mainFrame) { Let's take this one step further and ...
3 years, 11 months ago (2017-01-06 01:40:48 UTC) #4
luoe
3 years, 11 months ago (2017-01-06 20:17:28 UTC) #7
Nice patch!  After this change, there will be NetworkLog(NL)s when they were
null before.  ConsoleModel uses NL to attach the request to a ConsoleMessage. 
Let's check that console logs/errors from service workers look fine as well.

Powered by Google App Engine
This is Rietveld 408576698