Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

Issue 2616023003: [Devtools] Reverse dependency of ResourceTreeModel and NetworkLog (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
index e170ff5a3fed8d652ddc2b21bdceaaf552255a42..2ea1833c28c6a7d1db0d5692f6a8afb405b99328 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js
@@ -171,12 +171,13 @@ SDK.TargetManager = class extends Common.Object {
var networkManager = null;
var resourceTreeModel = null;
- if (target.hasNetworkCapability())
+ if (target.hasNetworkCapability()) {
networkManager = new SDK.NetworkManager(target);
- if (networkManager && target.hasDOMCapability()) {
- resourceTreeModel =
- new SDK.ResourceTreeModel(target, networkManager, SDK.SecurityOriginManager.fromTarget(target));
- new SDK.NetworkLog(target, resourceTreeModel, networkManager);
+ var networkLog = new SDK.NetworkLog(target, networkManager);
+ if (target.hasDOMCapability()) {
+ resourceTreeModel =
+ new SDK.ResourceTreeModel(target, networkManager, SDK.SecurityOriginManager.fromTarget(target), networkLog);
+ }
}
/** @type {!SDK.RuntimeModel} */

Powered by Google App Engine
This is Rietveld 408576698