Revert of Add CHECKs to ResourceLoader to investigate crashes

Revert of Add CHECKs to ResourceLoader to investigate crashes (patchset #1 id:1 of https://codereview.chromium.org/2619513002/ )

Reason for revert:
This seems to be causing WebKit Linux Trusty Leak to fail reliably, perhaps you don't need to test in the wild with a CHECK after all?

04:10:44.200 6804 worker/0 http/tests/htmlimports/import-async-previous-async.html crashed, (stderr lines):
04:10:44.200 6804   [1:1:0106/041043.551773:1549663839:FATAL:ResourceLoader.cpp(70)] Check failed: !m_loader. 
04:10:44.200 6804   #0 0x0000014b22ce base::debug::StackTrace::StackTrace()
04:10:44.200 6804   #1 0x0000014c110b logging::LogMessage::~LogMessage()
04:10:44.200 6804   #2 0x000002832215 blink::FinalizerTrait<>::finalize()
04:10:44.200 6804   #3 0x000000f0fae0 blink::NormalPage::sweep()
04:10:44.200 6804   #4 0x000000f0dd29 blink::BaseArena::completeSweep()
04:10:44.200 6804   #5 0x000000f12edc blink::ThreadState::completeSweep()
04:10:44.200 6804   #6 0x000000f14c40 blink::ThreadState::collectGarbage()
04:10:44.200 6804   #7 0x00000241a36f blink::V8GCController::gcEpilogue()
04:10:44.200 6804   #8 0x000000a85b05 v8::internal::Heap::PerformGarbageCollection()
04:10:44.200 6804   #9 0x000000a849bc v8::internal::Heap::CollectGarbage()
04:10:44.200 6804   #10 0x000000a83943 v8::internal::Heap::CollectAllGarbage()
04:10:44.200 6804   #11 0x00000241aa0b blink::V8GCController::collectAllGarbageForTesting()
04:10:44.200 6804   #12 0x0000023a11c7 blink::(anonymous namespace)::WebLeakDetectorImpl::collectGarbageAndReport()
04:10:44.200 6804   #13 0x00000148c109 _ZN3IPC8MessageTI34ShellViewMsg_TryLeakDetection_MetaSt5tupleIJEEvE8DispatchIN7content15BlinkTestRunnerES7_vMS7_FvvEEEbPKNS_7MessageEPT_PT0_PT1_T2_
04:10:44.200 6804   #14 0x00000148b980 content::BlinkTestRunner::OnMessageReceived()
04:10:44.201 6804   #15 0x0000020f3da2 content::RenderViewImpl::OnMessageReceived()
04:10:44.201 6804   #16 0x0000016616d5 IPC::ChannelProxy::Context::OnDispatchMessage()
04:10:44.201 6804   #17 0x000001525b0e base::debug::TaskAnnotator::RunTask()
04:10:44.201 6804   #18 0x00000231a9b2 blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue()
04:10:44.201 6804   #19 0x0000023195f4 blink::scheduler::TaskQueueManager::DoWork()
04:10:44.201 6804   #20 0x000001525b0e base::debug::TaskAnnotator::RunTask()
04:10:44.201 6804   #21 0x0000014c631d base::MessageLoop::RunTask()
04:10:44.201 6804   #22 0x0000014c6a65 base::MessageLoop::DoWork()
04:10:44.201 6804   #23 0x0000014c7a4a base::MessagePumpDefault::Run()
04:10:44.201 6804   #24 0x0000014c6047 base::MessageLoop::RunHandler()
04:10:44.201 6804   #25 0x0000014dfc5e base::RunLoop::Run()
04:10:44.201 6804   #26 0x000002110b80 content::RendererMain()
04:10:44.201 6804   #27 0x000000fc5887 content::RunZygote()
04:10:44.201 6804   #28 0x000000fc67fc content::ContentMainRunnerImpl::Run()
04:10:44.201 6804   #29 0x000000fbf760 content::ContentMain()
04:10:44.201 6804   #30 0x00000043ecf1 main
04:10:44.201 6804   #31 0x7f6e80c02f45 __libc_start_main
04:10:44.201 6804   #32 0x00000043ebd1 <unknown>

Original issue's description:
> Add CHECKs to ResourceLoader to investigate crashes
> 
> There are crash reports that |m_resource| is broken in
> ResourceLoader::didReceiveResponse. It is strange as ResourceLoader::m_resource
> is constant after its construction. To investigate the issue, this CL adds some
> CHECKs in ResourceLoader.
> 
> BUG=675947
> R=tyoshino@chromium.org
> 
> Review-Url: https://codereview.chromium.org/2619513002
> Cr-Commit-Position: refs/heads/master@{#441919}
> Committed: https://chromium.googlesource.com/chromium/src/+/0ff2bff5863ccfdc069ed54794104dc126c6daf9

TBR=tyoshino@chromium.org,yhirano@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=675947
Review-Url: https://codereview.chromium.org/2615993005
Cr-Commit-Position: refs/heads/master@{#441966}
Committed: https://chromium.googlesource.com/chromium/src/+/189cb4ad2d0122f768ecb4b165078bb87edab120

[dewittj, 2017-01-06 17:42:03]

The CQ bit was checked by dewittj@chromium.org

[dewittj, 2017-01-06 17:42:04]

Created Revert of Add CHECKs to ResourceLoader to investigate crashes

[commit-bot: I haz the power, 2017-01-06 17:42:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 17:43:32]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483724523704000, "parent_rev":
"2668d82b0edebec82ab5e4fc76e4aa65ff7efcd6", "commit_rev":
"189cb4ad2d0122f768ecb4b165078bb87edab120"}

[commit-bot: I haz the power, 2017-01-06 17:44:01]

Description was changed from

==========
Revert of Add CHECKs to ResourceLoader to investigate crashes (patchset #1 id:1
of https://codereview.chromium.org/2619513002/ )

Reason for revert:
This seems to be causing WebKit Linux Trusty Leak to fail reliably, perhaps you
don't need to test in the wild with a CHECK after all?

04:10:44.200 6804 worker/0
http/tests/htmlimports/import-async-previous-async.html crashed, (stderr lines):
04:10:44.200 6804  
[1:1:0106/041043.551773:1549663839:FATAL:ResourceLoader.cpp(70)] Check failed:
!m_loader. 
04:10:44.200 6804   #0 0x0000014b22ce base::debug::StackTrace::StackTrace()
04:10:44.200 6804   #1 0x0000014c110b logging::LogMessage::~LogMessage()
04:10:44.200 6804   #2 0x000002832215 blink::FinalizerTrait<>::finalize()
04:10:44.200 6804   #3 0x000000f0fae0 blink::NormalPage::sweep()
04:10:44.200 6804   #4 0x000000f0dd29 blink::BaseArena::completeSweep()
04:10:44.200 6804   #5 0x000000f12edc blink::ThreadState::completeSweep()
04:10:44.200 6804   #6 0x000000f14c40 blink::ThreadState::collectGarbage()
04:10:44.200 6804   #7 0x00000241a36f blink::V8GCController::gcEpilogue()
04:10:44.200 6804   #8 0x000000a85b05
v8::internal::Heap::PerformGarbageCollection()
04:10:44.200 6804   #9 0x000000a849bc v8::internal::Heap::CollectGarbage()
04:10:44.200 6804   #10 0x000000a83943 v8::internal::Heap::CollectAllGarbage()
04:10:44.200 6804   #11 0x00000241aa0b
blink::V8GCController::collectAllGarbageForTesting()
04:10:44.200 6804   #12 0x0000023a11c7 blink::(anonymous
namespace)::WebLeakDetectorImpl::collectGarbageAndReport()
04:10:44.200 6804   #13 0x00000148c109
_ZN3IPC8MessageTI34ShellViewMsg_TryLeakDetection_MetaSt5tupleIJEEvE8DispatchIN7content15BlinkTestRunnerES7_vMS7_FvvEEEbPKNS_7MessageEPT_PT0_PT1_T2_
04:10:44.200 6804   #14 0x00000148b980
content::BlinkTestRunner::OnMessageReceived()
04:10:44.201 6804   #15 0x0000020f3da2
content::RenderViewImpl::OnMessageReceived()
04:10:44.201 6804   #16 0x0000016616d5
IPC::ChannelProxy::Context::OnDispatchMessage()
04:10:44.201 6804   #17 0x000001525b0e base::debug::TaskAnnotator::RunTask()
04:10:44.201 6804   #18 0x00000231a9b2
blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue()
04:10:44.201 6804   #19 0x0000023195f4
blink::scheduler::TaskQueueManager::DoWork()
04:10:44.201 6804   #20 0x000001525b0e base::debug::TaskAnnotator::RunTask()
04:10:44.201 6804   #21 0x0000014c631d base::MessageLoop::RunTask()
04:10:44.201 6804   #22 0x0000014c6a65 base::MessageLoop::DoWork()
04:10:44.201 6804   #23 0x0000014c7a4a base::MessagePumpDefault::Run()
04:10:44.201 6804   #24 0x0000014c6047 base::MessageLoop::RunHandler()
04:10:44.201 6804   #25 0x0000014dfc5e base::RunLoop::Run()
04:10:44.201 6804   #26 0x000002110b80 content::RendererMain()
04:10:44.201 6804   #27 0x000000fc5887 content::RunZygote()
04:10:44.201 6804   #28 0x000000fc67fc content::ContentMainRunnerImpl::Run()
04:10:44.201 6804   #29 0x000000fbf760 content::ContentMain()
04:10:44.201 6804   #30 0x00000043ecf1 main
04:10:44.201 6804   #31 0x7f6e80c02f45 __libc_start_main
04:10:44.201 6804   #32 0x00000043ebd1 <unknown>

Original issue's description:
> Add CHECKs to ResourceLoader to investigate crashes
> 
> There are crash reports that |m_resource| is broken in
> ResourceLoader::didReceiveResponse. It is strange as
ResourceLoader::m_resource
> is constant after its construction. To investigate the issue, this CL adds
some
> CHECKs in ResourceLoader.
> 
> BUG=675947
> R=tyoshino@chromium.org
> 
> Review-Url: https://codereview.chromium.org/2619513002
> Cr-Commit-Position: refs/heads/master@{#441919}
> Committed:
https://chromium.googlesource.com/chromium/src/+/0ff2bff5863ccfdc069ed5479410...

TBR=tyoshino@chromium.org,yhirano@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=675947
==========

to

==========
Revert of Add CHECKs to ResourceLoader to investigate crashes (patchset #1 id:1
of https://codereview.chromium.org/2619513002/ )

Reason for revert:
This seems to be causing WebKit Linux Trusty Leak to fail reliably, perhaps you
don't need to test in the wild with a CHECK after all?

04:10:44.200 6804 worker/0
http/tests/htmlimports/import-async-previous-async.html crashed, (stderr lines):
04:10:44.200 6804  
[1:1:0106/041043.551773:1549663839:FATAL:ResourceLoader.cpp(70)] Check failed:
!m_loader. 
04:10:44.200 6804   #0 0x0000014b22ce base::debug::StackTrace::StackTrace()
04:10:44.200 6804   #1 0x0000014c110b logging::LogMessage::~LogMessage()
04:10:44.200 6804   #2 0x000002832215 blink::FinalizerTrait<>::finalize()
04:10:44.200 6804   #3 0x000000f0fae0 blink::NormalPage::sweep()
04:10:44.200 6804   #4 0x000000f0dd29 blink::BaseArena::completeSweep()
04:10:44.200 6804   #5 0x000000f12edc blink::ThreadState::completeSweep()
04:10:44.200 6804   #6 0x000000f14c40 blink::ThreadState::collectGarbage()
04:10:44.200 6804   #7 0x00000241a36f blink::V8GCController::gcEpilogue()
04:10:44.200 6804   #8 0x000000a85b05
v8::internal::Heap::PerformGarbageCollection()
04:10:44.200 6804   #9 0x000000a849bc v8::internal::Heap::CollectGarbage()
04:10:44.200 6804   #10 0x000000a83943 v8::internal::Heap::CollectAllGarbage()
04:10:44.200 6804   #11 0x00000241aa0b
blink::V8GCController::collectAllGarbageForTesting()
04:10:44.200 6804   #12 0x0000023a11c7 blink::(anonymous
namespace)::WebLeakDetectorImpl::collectGarbageAndReport()
04:10:44.200 6804   #13 0x00000148c109
_ZN3IPC8MessageTI34ShellViewMsg_TryLeakDetection_MetaSt5tupleIJEEvE8DispatchIN7content15BlinkTestRunnerES7_vMS7_FvvEEEbPKNS_7MessageEPT_PT0_PT1_T2_
04:10:44.200 6804   #14 0x00000148b980
content::BlinkTestRunner::OnMessageReceived()
04:10:44.201 6804   #15 0x0000020f3da2
content::RenderViewImpl::OnMessageReceived()
04:10:44.201 6804   #16 0x0000016616d5
IPC::ChannelProxy::Context::OnDispatchMessage()
04:10:44.201 6804   #17 0x000001525b0e base::debug::TaskAnnotator::RunTask()
04:10:44.201 6804   #18 0x00000231a9b2
blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue()
04:10:44.201 6804   #19 0x0000023195f4
blink::scheduler::TaskQueueManager::DoWork()
04:10:44.201 6804   #20 0x000001525b0e base::debug::TaskAnnotator::RunTask()
04:10:44.201 6804   #21 0x0000014c631d base::MessageLoop::RunTask()
04:10:44.201 6804   #22 0x0000014c6a65 base::MessageLoop::DoWork()
04:10:44.201 6804   #23 0x0000014c7a4a base::MessagePumpDefault::Run()
04:10:44.201 6804   #24 0x0000014c6047 base::MessageLoop::RunHandler()
04:10:44.201 6804   #25 0x0000014dfc5e base::RunLoop::Run()
04:10:44.201 6804   #26 0x000002110b80 content::RendererMain()
04:10:44.201 6804   #27 0x000000fc5887 content::RunZygote()
04:10:44.201 6804   #28 0x000000fc67fc content::ContentMainRunnerImpl::Run()
04:10:44.201 6804   #29 0x000000fbf760 content::ContentMain()
04:10:44.201 6804   #30 0x00000043ecf1 main
04:10:44.201 6804   #31 0x7f6e80c02f45 __libc_start_main
04:10:44.201 6804   #32 0x00000043ebd1 <unknown>

Original issue's description:
> Add CHECKs to ResourceLoader to investigate crashes
> 
> There are crash reports that |m_resource| is broken in
> ResourceLoader::didReceiveResponse. It is strange as
ResourceLoader::m_resource
> is constant after its construction. To investigate the issue, this CL adds
some
> CHECKs in ResourceLoader.
> 
> BUG=675947
> R=tyoshino@chromium.org
> 
> Review-Url: https://codereview.chromium.org/2619513002
> Cr-Commit-Position: refs/heads/master@{#441919}
> Committed:
https://chromium.googlesource.com/chromium/src/+/0ff2bff5863ccfdc069ed5479410...

TBR=tyoshino@chromium.org,yhirano@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=675947

Review-Url: https://codereview.chromium.org/2615993005
Cr-Commit-Position: refs/heads/master@{#441966}
Committed:
https://chromium.googlesource.com/chromium/src/+/189cb4ad2d0122f768ecb4b16507...
==========

[commit-bot: I haz the power, 2017-01-06 17:44:02]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/189cb4ad2d0122f768ecb4b16507...

[tyoshino (SeeGerritForStatus), 2017-01-10 07:30:42]

lgtm. Thanks!