Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2615903003: Fix for resynthesizing libraries with invalid part URIs. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Un-fail other tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -229 lines) Patch
M pkg/analysis_server/test/services/completion/dart/uri_contributor_test.dart View 1 2 chunks +0 lines, -222 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 3 chunks +15 lines, -6 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 2 chunks +5 lines, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 11 months ago (2017-01-05 20:01:56 UTC) #1
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-05 20:05:38 UTC) #2
Paul Berry
lgtm
3 years, 11 months ago (2017-01-05 20:15:36 UTC) #3
scheglov
3 years, 11 months ago (2017-01-05 20:26:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d8c426bb85ddfb16560ff3e31088594e73ed5739 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698