pkg/analysis_server/test/services/completion/dart/uri_contributor_test.dart - Issue 2615903003: Fix for resynthesizing libraries with invalid part URIs.

Unified Diff: pkg/analysis_server/test/services/completion/dart/uri_contributor_test.dart

Issue 2615903003: Fix for resynthesizing libraries with invalid part URIs. (Closed)

Patch Set: Un-fail other tests. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Index: pkg/analysis_server/test/services/completion/dart/uri_contributor_test.dart

diff --git a/pkg/analysis_server/test/services/completion/dart/uri_contributor_test.dart b/pkg/analysis_server/test/services/completion/dart/uri_contributor_test.dart

index 603a1c2b620c188fe266cbec1d84b37997417bc0..2df266944959770797129ef6ac4e5e1263928ae8 100644

--- a/pkg/analysis_server/test/services/completion/dart/uri_contributor_test.dart

+++ b/pkg/analysis_server/test/services/completion/dart/uri_contributor_test.dart

@@ -468,117 +468,6 @@ class UriContributorTest extends DartCompletionContributorTest {

class UriContributorTest_Driver extends UriContributorTest {

@override

bool get enableNewAnalysisDriver => true;

- @failingTest

- @override

- test_part_file() {

-// NoSuchMethodError: The getter 'uri' was called on null.

-// Receiver: null

-// Tried calling: uri

-// dart:core Object.noSuchMethod

-// package:analyzer/src/summary/resynthesize.dart 233:40 SummaryResynthesizer.getLibraryElement.<fn>

-// dart:collection _HashVMBase&MapMixin&&_LinkedHashMapMixin.putIfAbsent

-// package:analyzer/src/summary/resynthesize.dart 209:36 SummaryResynthesizer.getLibraryElement

-// package:analyzer/src/summary/package_bundle_reader.dart 206:27 ResynthesizerResultProvider.compute

-// package:analyzer/src/context/context.dart 573:52 AnalysisContextImpl.aboutToComputeResult.<fn>

-// package:analyzer/src/generated/utilities_general.dart 189:15 _PerformanceTagImpl.makeCurrentWhile

-// package:analyzer/src/context/context.dart 571:42 AnalysisContextImpl.aboutToComputeResult

-// package:analyzer/src/task/driver.dart 746:21 WorkItem.gatherInputs

-// package:analyzer/src/task/driver.dart 879:17 _WorkOrderDependencyWalker.getNextInput

-// package:analyzer/src/task/driver.dart 414:35 CycleAwareDependencyWalker.getNextStronglyConnectedComponent

-// package:analyzer/src/task/driver.dart 845:31 WorkOrder.moveNext.<fn>

-// package:analyzer/src/generated/utilities_general.dart 189:15 _PerformanceTagImpl.makeCurrentWhile

-// package:analyzer/src/task/driver.dart 837:44 WorkOrder.moveNext

-// package:analyzer/src/task/driver.dart 108:30 AnalysisDriver.computeResult

-// package:analyzer/src/context/context.dart 723:14 AnalysisContextImpl.computeResult

-// package:analyzer/src/context/context.dart 1292:12 AnalysisContextImpl.resolveCompilationUnit2

-// package:analyzer/src/dart/analysis/driver.dart 656:56 AnalysisDriver._computeAnalysisResult.<fn>

-// package:analyzer/src/dart/analysis/driver.dart 1427:15 PerformanceLog.run

-// package:analyzer/src/dart/analysis/driver.dart 643:20 AnalysisDriver._computeAnalysisResult

-// package:analyzer/src/dart/analysis/driver.dart 910:33 AnalysisDriver._performWork.<async>

- return super.test_part_file();

- }

- @failingTest

- @override

- test_part_file2() {

-// Task failed: BuildCompilationUnitElementTask for source /

-// Unexpected exception while performing BuildCompilationUnitElementTask for source /

-// #0 AnalysisTask._safelyPerform (package:analyzer/task/model.dart:333:7)

-// #1 AnalysisTask.perform (package:analyzer/task/model.dart:220:7)

-// #2 AnalysisDriver.performWorkItem (package:analyzer/src/task/driver.dart:284:10)

-// #3 AnalysisDriver.computeResult (package:analyzer/src/task/driver.dart:109:22)

-// #4 AnalysisContextImpl.computeResult (package:analyzer/src/context/context.dart:723:14)

-// #5 AnalysisContextImpl.computeErrors (package:analyzer/src/context/context.dart:665:12)

-// #6 AnalysisDriver._computeAnalysisResult.<anonymous closure> (package:analyzer/src/dart/analysis/driver.dart:658:54)

-// #7 PerformanceLog.run (package:analyzer/src/dart/analysis/driver.dart:1427:15)

-// #8 AnalysisDriver._computeAnalysisResult (package:analyzer/src/dart/analysis/driver.dart:643:20)

-// #9 AnalysisDriver._performWork.<_performWork_async_body> (package:analyzer/src/dart/analysis/driver.dart:910:33)

-// #10 Future.Future.microtask.<anonymous closure> (dart:async/future.dart:184)

-// #11 _rootRun (dart:async/zone.dart:1146)

-// #12 _CustomZone.run (dart:async/zone.dart:1026)

-// #13 _CustomZone.runGuarded (dart:async/zone.dart:924)

-// #14 _CustomZone.bindCallback.<anonymous closure> (dart:async/zone.dart:951)

-// #15 _rootRun (dart:async/zone.dart:1150)

-// #16 _CustomZone.run (dart:async/zone.dart:1026)

-// #17 _CustomZone.runGuarded (dart:async/zone.dart:924)

-// #18 _CustomZone.bindCallback.<anonymous closure> (dart:async/zone.dart:951)

-// #19 _microtaskLoop (dart:async/schedule_microtask.dart:41)

-// #20 _startMicrotaskLoop (dart:async/schedule_microtask.dart:50)

-// #21 _Timer._runTimers (dart:isolate-patch/timer_impl.dart:394)

-// #22 _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:414)

-// #23 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:148)

-//

-// Caused by Exception: Unit element not found in summary: file:///proj/completion.dart;file:///

-// #0 SummaryResynthesizer.getElement (package:analyzer/src/summary/resynthesize.dart:124:9)

-// #1 ResynthesizerResultProvider.compute (package:analyzer/src/summary/package_bundle_reader.dart:265:53)

-// #2 AnalysisContextImpl.aboutToComputeResult.<anonymous closure> (package:analyzer/src/context/context.dart:573:52)

-// #3 _PerformanceTagImpl.makeCurrentWhile (package:analyzer/src/generated/utilities_general.dart:189:15)

-// #4 AnalysisContextImpl.aboutToComputeResult (package:analyzer/src/context/context.dart:571:42)

-// #5 BuildCompilationUnitElementTask.internalPerform (package:analyzer/src/task/dart.dart:1071:27)

-// #6 AnalysisTask._safelyPerform (package:analyzer/task/model.dart:321:9)

-// #7 AnalysisTask.perform (package:analyzer/task/model.dart:220:7)

-// #8 AnalysisDriver.performWorkItem (package:analyzer/src/task/driver.dart:284:10)

-// #9 AnalysisDriver.computeResult (package:analyzer/src/task/driver.dart:109:22)

-// #10 AnalysisContextImpl.computeResult (package:analyzer/src/context/context.dart:723:14)

-// #11 AnalysisContextImpl.computeErrors (package:analyzer/src/context/context.dart:665:12)

-// #12 AnalysisDriver._computeAnalysisResult.<anonymous closure> (package:analyzer/src/dart/analysis/driver.dart:658:54)

-// #13 PerformanceLog.run (package:analyzer/src/dart/analysis/driver.dart:1427:15)

-// #14 AnalysisDriver._computeAnalysisResult (package:analyzer/src/dart/analysis/driver.dart:643:20)

-// #15 AnalysisDriver._performWork.<_performWork_async_body> (package:analyzer/src/dart/analysis/driver.dart:910:33)

-// #16 Future.Future.microtask.<anonymous closure> (dart:async/future.dart:184)

-// #17 _rootRun (dart:async/zone.dart:1146)

-// #18 _CustomZone.run (dart:async/zone.dart:1026)

-// #19 _CustomZone.runGuarded (dart:async/zone.dart:924)

-// #20 _CustomZone.bindCallback.<anonymous closure> (dart:async/zone.dart:951)

-// #21 _rootRun (dart:async/zone.dart:1150)

-// #22 _CustomZone.run (dart:async/zone.dart:1026)

-// #23 _CustomZone.runGuarded (dart:async/zone.dart:924)

-// #24 _CustomZone.bindCallback.<anonymous closure> (dart:async/zone.dart:951)

-// #25 _microtaskLoop (dart:async/schedule_microtask.dart:41)

-// #26 _startMicrotaskLoop (dart:async/schedule_microtask.dart:50)

-// #27 _Timer._runTimers (dart:isolate-patch/timer_impl.dart:394)

-// #28 _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:414)

-// #29 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:148)

-// return super.test_part_file2();

- fail('Throws background exception.');

- }

- @failingTest

- @override

- test_part_file_child() {

-// expected foo/bar.dart CompletionSuggestionKind.IMPORT null

-// found

- return super.test_part_file_child();

- }

- @failingTest

- @override

- test_part_file_parent() {

-// expected foo/bar.dart CompletionSuggestionKind.IMPORT null

-// found

- return super.test_part_file_parent();

- }

}

@reflectiveTest

@@ -751,117 +640,6 @@ class UriContributorWindowsTest extends DartCompletionContributorTest {

class UriContributorWindowsTest_Driver extends UriContributorWindowsTest {