Revert of Don't paint underline or selections over ellipsis in mixed-flow contexts

Revert of Don't paint underline or selections over ellipsis in mixed-flow contexts (patchset #3 id:40001 of https://codereview.chromium.org/2594983002/ )

Reason for revert:
Causes test failures on Win10 Win7 bots:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win10/builds/18739

webkit_tests webkit_tests

unexpected_failures:
fast/forms/select/menulist-appearance-basic.html
fast/forms/select/menulist-style-color.html
fast/forms/select/select-selected.html
fast/forms/select/menulist-width-change.html
fast/forms/select/option-text-clip.html
fast/forms/select/option-script.html
fast/forms/select/option-strip-whitespace.html
fast/forms/color/input-appearance-color.html
fast/forms/select/select-dirty-parent-pref-widths.html
fast/forms/select/select-initial-position.html
fast/forms/select/menulist-deselect-update.html
fast/forms/select/select-change-listbox-to-popup.html
fast/forms/select/select-background-none.html
fast/forms/select/menulist-update-text-popup.html
fast/forms/select/select-baseline.html

Original issue's description:
> Don't paint underline or selections over ellipsis in mixed-flow contexts
>
> Also, ensure the selected text is painted correctly when an ellipsis is present
> in a mixed-flow context (e.g. ltr text in an rtl container).
>
> BUG=642454, 642450, 642460
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4
> Cr-Commit-Position: refs/heads/master@{#441486}

TBR=eae@chromium.org,szager@chromium.org,robhogan@gmail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642454, 642450, 642460
Committed: https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d
Cr-Commit-Position: refs/heads/master@{#441599}

[loyso (OOO), 2017-01-05 06:24:55]

The CQ bit was checked by loyso@chromium.org

[loyso (OOO), 2017-01-05 06:24:55]

Created Revert of Don't paint underline or selections over ellipsis in
mixed-flow contexts

[commit-bot: I haz the power, 2017-01-05 06:25:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 06:25:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 06:25:41]

Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations:
While running git apply --index -p1;
  error: patch failed: third_party/WebKit/LayoutTests/TestExpectations:1233
  error: third_party/WebKit/LayoutTests/TestExpectations: patch does not apply

Patch:       third_party/WebKit/LayoutTests/TestExpectations
Index: third_party/WebKit/LayoutTests/TestExpectations
diff --git a/third_party/WebKit/LayoutTests/TestExpectations
b/third_party/WebKit/LayoutTests/TestExpectations
index
0f82498e7825fec854245a6e8a6edc6ed8b8adf9..d31cb5cbbb28930ad63d828fb3863080245e4eab
100644
--- a/third_party/WebKit/LayoutTests/TestExpectations
+++ b/third_party/WebKit/LayoutTests/TestExpectations
@@ -1233,19 +1233,6 @@
 crbug.com/528062 [ Win ]
virtual/mojo-loading/http/tests/security/xssAuditor/cached-frame.html [ Failure
]
 crbug.com/528062 [ Win ]
virtual/mojo-loading/http/tests/security/xssAuditor/chunked-big-script.html [
Failure ]
 
-crbug.com/642454 [ Win Mac ]
editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed.html
[ NeedsRebaseline ]
-crbug.com/642454 [ Win Mac ]
editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed.html
[ NeedsRebaseline ]
-crbug.com/642454 [ Win Mac ]
editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl.html [
NeedsRebaseline ]
-crbug.com/642454 [ Win Mac ]
editing/selection/dont-select-text-overflow-ellipsis-when-wrapping.html [
NeedsRebaseline ]
-crbug.com/642454 [ Win Mac ]
editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2.html [
NeedsRebaseline ]
-crbug.com/642454 [ Win Mac ]
editing/selection/select-text-overflow-ellipsis-mixed-in-ltr.html [
NeedsRebaseline ]
-crbug.com/642454 [ Win Mac ]
editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2.html [
NeedsRebaseline ]
-crbug.com/642454 [ Win Mac ] fast/css/text-overflow-ellipsis-strict.html [
NeedsRebaseline ]
-crbug.com/642454 [ Win Mac ] fast/css/text-overflow-ellipsis.html [
NeedsRebaseline ]
-crbug.com/642454 [ Win Mac ]
fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2.html [ NeedsRebaseline ]
-crbug.com/642454 [ Win Mac ]
fast/text/ellipsis-mixed-text-in-ltr-flow-underline.html [ NeedsRebaseline ]
-crbug.com/642454 [ Win Mac ]
fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2.html [ NeedsRebaseline ]
-
 crbug.com/392706 virtual/threaded/animations/play-state-initially-paused.html [
Failure ]
 
 # Part of a larger issue referenced in the bug. This specific issue will be
fixed shortly.

[loyso (OOO), 2017-01-05 06:30:01]

The CQ bit was checked by loyso@chromium.org

[commit-bot: I haz the power, 2017-01-05 06:30:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 06:31:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1483597801631000, "parent_rev":
"8a80d34eb5320310995565edfd685538c65b9bf6", "commit_rev":
"4bd117e2caa4b5e8df0199a780110d442b6a45a8"}

[commit-bot: I haz the power, 2017-01-05 06:32:20]

Description was changed from

==========
Revert of Don't paint underline or selections over ellipsis in mixed-flow
contexts (patchset #3 id:40001 of https://codereview.chromium.org/2594983002/ )

Reason for revert:
Causes test failures on Win10 Win7 bots:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win1...

webkit_tests webkit_tests

unexpected_failures:
fast/forms/select/menulist-appearance-basic.html
fast/forms/select/menulist-style-color.html
fast/forms/select/select-selected.html
fast/forms/select/menulist-width-change.html
fast/forms/select/option-text-clip.html
fast/forms/select/option-script.html
fast/forms/select/option-strip-whitespace.html
fast/forms/color/input-appearance-color.html
fast/forms/select/select-dirty-parent-pref-widths.html
fast/forms/select/select-initial-position.html
fast/forms/select/menulist-deselect-update.html
fast/forms/select/select-change-listbox-to-popup.html
fast/forms/select/select-background-none.html
fast/forms/select/menulist-update-text-popup.html
fast/forms/select/select-baseline.html

Original issue's description:
> Don't paint underline or selections over ellipsis in mixed-flow contexts
> 
> Also, ensure the selected text is painted correctly when an ellipsis is
present
> in a mixed-flow context (e.g. ltr text in an rtl container).
> 
> BUG=642454, 642450, 642460
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4
> Cr-Commit-Position: refs/heads/master@{#441486}

TBR=eae@chromium.org,szager@chromium.org,robhogan@gmail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642454, 642450, 642460
==========

to

==========
Revert of Don't paint underline or selections over ellipsis in mixed-flow
contexts (patchset #3 id:40001 of https://codereview.chromium.org/2594983002/ )

Reason for revert:
Causes test failures on Win10 Win7 bots:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win1...

webkit_tests webkit_tests

unexpected_failures:
fast/forms/select/menulist-appearance-basic.html
fast/forms/select/menulist-style-color.html
fast/forms/select/select-selected.html
fast/forms/select/menulist-width-change.html
fast/forms/select/option-text-clip.html
fast/forms/select/option-script.html
fast/forms/select/option-strip-whitespace.html
fast/forms/color/input-appearance-color.html
fast/forms/select/select-dirty-parent-pref-widths.html
fast/forms/select/select-initial-position.html
fast/forms/select/menulist-deselect-update.html
fast/forms/select/select-change-listbox-to-popup.html
fast/forms/select/select-background-none.html
fast/forms/select/menulist-update-text-popup.html
fast/forms/select/select-baseline.html

Original issue's description:
> Don't paint underline or selections over ellipsis in mixed-flow contexts
>
> Also, ensure the selected text is painted correctly when an ellipsis is
present
> in a mixed-flow context (e.g. ltr text in an rtl container).
>
> BUG=642454, 642450, 642460
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4
> Cr-Commit-Position: refs/heads/master@{#441486}

TBR=eae@chromium.org,szager@chromium.org,robhogan@gmail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642454, 642450, 642460

Review-Url: https://codereview.chromium.org/2615843002
Committed:
https://chromium.googlesource.com/chromium/src/+/4bd117e2caa4b5e8df0199a78011...
==========

[commit-bot: I haz the power, 2017-01-05 06:32:21]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4bd117e2caa4b5e8df0199a78011...

[commit-bot: I haz the power, 2017-01-05 06:36:03]

Description was changed from

==========
Revert of Don't paint underline or selections over ellipsis in mixed-flow
contexts (patchset #3 id:40001 of https://codereview.chromium.org/2594983002/ )

Reason for revert:
Causes test failures on Win10 Win7 bots:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win1...

webkit_tests webkit_tests

unexpected_failures:
fast/forms/select/menulist-appearance-basic.html
fast/forms/select/menulist-style-color.html
fast/forms/select/select-selected.html
fast/forms/select/menulist-width-change.html
fast/forms/select/option-text-clip.html
fast/forms/select/option-script.html
fast/forms/select/option-strip-whitespace.html
fast/forms/color/input-appearance-color.html
fast/forms/select/select-dirty-parent-pref-widths.html
fast/forms/select/select-initial-position.html
fast/forms/select/menulist-deselect-update.html
fast/forms/select/select-change-listbox-to-popup.html
fast/forms/select/select-background-none.html
fast/forms/select/menulist-update-text-popup.html
fast/forms/select/select-baseline.html

Original issue's description:
> Don't paint underline or selections over ellipsis in mixed-flow contexts
>
> Also, ensure the selected text is painted correctly when an ellipsis is
present
> in a mixed-flow context (e.g. ltr text in an rtl container).
>
> BUG=642454, 642450, 642460
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4
> Cr-Commit-Position: refs/heads/master@{#441486}

TBR=eae@chromium.org,szager@chromium.org,robhogan@gmail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642454, 642450, 642460

Review-Url: https://codereview.chromium.org/2615843002
Committed:
https://chromium.googlesource.com/chromium/src/+/4bd117e2caa4b5e8df0199a78011...
==========

to

==========
Revert of Don't paint underline or selections over ellipsis in mixed-flow
contexts (patchset #3 id:40001 of https://codereview.chromium.org/2594983002/ )

Reason for revert:
Causes test failures on Win10 Win7 bots:
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win1...

webkit_tests webkit_tests

unexpected_failures:
fast/forms/select/menulist-appearance-basic.html
fast/forms/select/menulist-style-color.html
fast/forms/select/select-selected.html
fast/forms/select/menulist-width-change.html
fast/forms/select/option-text-clip.html
fast/forms/select/option-script.html
fast/forms/select/option-strip-whitespace.html
fast/forms/color/input-appearance-color.html
fast/forms/select/select-dirty-parent-pref-widths.html
fast/forms/select/select-initial-position.html
fast/forms/select/menulist-deselect-update.html
fast/forms/select/select-change-listbox-to-popup.html
fast/forms/select/select-background-none.html
fast/forms/select/menulist-update-text-popup.html
fast/forms/select/select-baseline.html

Original issue's description:
> Don't paint underline or selections over ellipsis in mixed-flow contexts
>
> Also, ensure the selected text is painted correctly when an ellipsis is
present
> in a mixed-flow context (e.g. ltr text in an rtl container).
>
> BUG=642454, 642450, 642460
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4
> Cr-Commit-Position: refs/heads/master@{#441486}

TBR=eae@chromium.org,szager@chromium.org,robhogan@gmail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=642454, 642450, 642460

Committed: https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d
Cr-Commit-Position: refs/heads/master@{#441599}
==========

[commit-bot: I haz the power, 2017-01-05 06:36:04]

Patchset 1 (id:??) landed as
https://crrev.com/1142d494094d29842cf057bf032c0f3985d7060d
Cr-Commit-Position: refs/heads/master@{#441599}

[rhogan, 2017-01-05 06:58:46]

This build bot isn't accessible to me. Where can I see the failures that
caused this roll out?

On Thu, 5 Jan 2017 06:24 , <loyso@chromium.org> wrote:

> Reviewers: eae, szager1, rhogan
> CL: https://codereview.chromium.org/2615843002/
>
> Message:
> Created Revert of Don't paint underline or selections over ellipsis in
> mixed-flow contexts
>
> Description:
> Revert of Don't paint underline or selections over ellipsis in mixed-flow
> contexts (patchset #3 id:40001 of
> https://codereview.chromium.org/2594983002/ )
>
> Reason for revert:
> Causes test failures on Win10 Win7 bots:
>
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win1...
>
> webkit_tests webkit_tests
>
> unexpected_failures:
> fast/forms/select/menulist-appearance-basic.html
> fast/forms/select/menulist-style-color.html
> fast/forms/select/select-selected.html
> fast/forms/select/menulist-width-change.html
> fast/forms/select/option-text-clip.html
> fast/forms/select/option-script.html
> fast/forms/select/option-strip-whitespace.html
> fast/forms/color/input-appearance-color.html
> fast/forms/select/select-dirty-parent-pref-widths.html
> fast/forms/select/select-initial-position.html
> fast/forms/select/menulist-deselect-update.html
> fast/forms/select/select-change-listbox-to-popup.html
> fast/forms/select/select-background-none.html
> fast/forms/select/menulist-update-text-popup.html
> fast/forms/select/select-baseline.html
>
> Original issue's description:
> > Don't paint underline or selections over ellipsis in mixed-flow contexts
> >
> > Also, ensure the selected text is painted correctly when an ellipsis is
> present
> > in a mixed-flow context (e.g. ltr text in an rtl container).
> >
> > BUG=642454, 642450, 642460
> >
>
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> >
> > Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4
> > Cr-Commit-Position: refs/heads/master@{#441486}
>
> TBR=eae@chromium.org,szager@chromium.org,robhogan@gmail.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=642454, 642450, 642460
>
> Affected files (+17, -371 lines):
> M third_party/WebKit/LayoutTests/TestExpectations
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2.html
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2.html
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt
> M
>
third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
> M
>
third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png
> M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
> M third_party/WebKit/Source/core/paint/TextPainter.h
> M third_party/WebKit/Source/core/paint/TextPainter.cpp
>
>
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[rhogan, 2017-01-05 06:58:47]

This build bot isn't accessible to me. Where can I see the failures that
caused this roll out?

On Thu, 5 Jan 2017 06:24 , <loyso@chromium.org> wrote:

> Reviewers: eae, szager1, rhogan
> CL: https://codereview.chromium.org/2615843002/
>
> Message:
> Created Revert of Don't paint underline or selections over ellipsis in
> mixed-flow contexts
>
> Description:
> Revert of Don't paint underline or selections over ellipsis in mixed-flow
> contexts (patchset #3 id:40001 of
> https://codereview.chromium.org/2594983002/ )
>
> Reason for revert:
> Causes test failures on Win10 Win7 bots:
>
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win1...
>
> webkit_tests webkit_tests
>
> unexpected_failures:
> fast/forms/select/menulist-appearance-basic.html
> fast/forms/select/menulist-style-color.html
> fast/forms/select/select-selected.html
> fast/forms/select/menulist-width-change.html
> fast/forms/select/option-text-clip.html
> fast/forms/select/option-script.html
> fast/forms/select/option-strip-whitespace.html
> fast/forms/color/input-appearance-color.html
> fast/forms/select/select-dirty-parent-pref-widths.html
> fast/forms/select/select-initial-position.html
> fast/forms/select/menulist-deselect-update.html
> fast/forms/select/select-change-listbox-to-popup.html
> fast/forms/select/select-background-none.html
> fast/forms/select/menulist-update-text-popup.html
> fast/forms/select/select-baseline.html
>
> Original issue's description:
> > Don't paint underline or selections over ellipsis in mixed-flow contexts
> >
> > Also, ensure the selected text is painted correctly when an ellipsis is
> present
> > in a mixed-flow context (e.g. ltr text in an rtl container).
> >
> > BUG=642454, 642450, 642460
> >
>
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> >
> > Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4
> > Cr-Commit-Position: refs/heads/master@{#441486}
>
> TBR=eae@chromium.org,szager@chromium.org,robhogan@gmail.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=642454, 642450, 642460
>
> Affected files (+17, -371 lines):
> M third_party/WebKit/LayoutTests/TestExpectations
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2.html
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2.html
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt
> M
>
third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
> M
>
third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png
> M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
> M third_party/WebKit/Source/core/paint/TextPainter.h
> M third_party/WebKit/Source/core/paint/TextPainter.cpp
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[loyso (OOO), 2017-01-05 07:08:20]

This should be visible for everyone:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/1...

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/1...

On Thu, Jan 5, 2017 at 5:58 PM, Robert Hogan <robhogan@gmail.com> wrote:

> This build bot isn't accessible to me. Where can I see the failures that
> caused this roll out?
>
>
> On Thu, 5 Jan 2017 06:24 , <loyso@chromium.org> wrote:
>
>> Reviewers: eae, szager1, rhogan
>> CL: https://codereview.chromium.org/2615843002/
>>
>> Message:
>> Created Revert of Don't paint underline or selections over ellipsis in
>> mixed-flow contexts
>>
>> Description:
>> Revert of Don't paint underline or selections over ellipsis in mixed-flow
>> contexts (patchset #3 id:40001 of https://codereview.chromium.
>> org/2594983002/ )
>>
>> Reason for revert:
>> Causes test failures on Win10 Win7 bots:
>> https://uberchromegw.corp.google.com/i/chromium.webkit/
>> builders/WebKit%20Win10/builds/18739
>>
>> webkit_tests webkit_tests
>>
>> unexpected_failures:
>> fast/forms/select/menulist-appearance-basic.html
>> fast/forms/select/menulist-style-color.html
>> fast/forms/select/select-selected.html
>> fast/forms/select/menulist-width-change.html
>> fast/forms/select/option-text-clip.html
>> fast/forms/select/option-script.html
>> fast/forms/select/option-strip-whitespace.html
>> fast/forms/color/input-appearance-color.html
>> fast/forms/select/select-dirty-parent-pref-widths.html
>> fast/forms/select/select-initial-position.html
>> fast/forms/select/menulist-deselect-update.html
>> fast/forms/select/select-change-listbox-to-popup.html
>> fast/forms/select/select-background-none.html
>> fast/forms/select/menulist-update-text-popup.html
>> fast/forms/select/select-baseline.html
>>
>> Original issue's description:
>> > Don't paint underline or selections over ellipsis in mixed-flow contexts
>> >
>> > Also, ensure the selected text is painted correctly when an ellipsis is
>> present
>> > in a mixed-flow context (e.g. ltr text in an rtl container).
>> >
>> > BUG=642454, 642450, 642460
>> >
>> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:
>> linux_layout_tests_slimming_paint_v2
>> >
>> > Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4
>> > Cr-Commit-Position: refs/heads/master@{#441486}
>>
>> TBR=eae@chromium.org,szager@chromium.org,robhogan@gmail.com
>> # Skipping CQ checks because original CL landed less than 1 days ago.
>> NOPRESUBMIT=true
>> NOTREECHECKS=true
>> NOTRY=true
>> BUG=642454, 642450, 642460
>>
>> Affected files (+17, -371 lines):
>> M third_party/WebKit/LayoutTests/TestExpectations
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping.html
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping-expected.png
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping-expected.txt
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed.html
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping-rtl.html
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed.html
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt
>> D third_party/WebKit/LayoutTests/editing/selection/
>> select-text-overflow-ellipsis-mixed-in-ltr-2.html
>> D third_party/WebKit/LayoutTests/editing/selection/
>> select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
>> D third_party/WebKit/LayoutTests/editing/selection/
>> select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt
>> D third_party/WebKit/LayoutTests/editing/selection/
>> select-text-overflow-ellipsis-mixed-in-rtl-2.html
>> D third_party/WebKit/LayoutTests/editing/selection/
>> select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
>> D third_party/WebKit/LayoutTests/editing/selection/
>> select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt
>> D third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-
>> flow-underline-2.html
>> D third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-
>> flow-underline-2-expected.png
>> D third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-
>> flow-underline-2-expected.txt
>> D third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-
>> flow-underline-2.html
>> D third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-
>> flow-underline-2-expected.png
>> D third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-
>> flow-underline-2-expected.txt
>> M third_party/WebKit/LayoutTests/platform/linux/
>> editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
>> M third_party/WebKit/LayoutTests/platform/linux/
>> fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png
>> M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
>> M third_party/WebKit/Source/core/paint/TextPainter.h
>> M third_party/WebKit/Source/core/paint/TextPainter.cpp
>>
>>
>>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[loyso (OOO), 2017-01-05 07:08:30]

This should be visible for everyone:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/1...

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/1...

On Thu, Jan 5, 2017 at 5:58 PM, Robert Hogan <robhogan@gmail.com> wrote:

> This build bot isn't accessible to me. Where can I see the failures that
> caused this roll out?
>
>
> On Thu, 5 Jan 2017 06:24 , <loyso@chromium.org> wrote:
>
>> Reviewers: eae, szager1, rhogan
>> CL: https://codereview.chromium.org/2615843002/
>>
>> Message:
>> Created Revert of Don't paint underline or selections over ellipsis in
>> mixed-flow contexts
>>
>> Description:
>> Revert of Don't paint underline or selections over ellipsis in mixed-flow
>> contexts (patchset #3 id:40001 of https://codereview.chromium.
>> org/2594983002/ )
>>
>> Reason for revert:
>> Causes test failures on Win10 Win7 bots:
>> https://uberchromegw.corp.google.com/i/chromium.webkit/
>> builders/WebKit%20Win10/builds/18739
>>
>> webkit_tests webkit_tests
>>
>> unexpected_failures:
>> fast/forms/select/menulist-appearance-basic.html
>> fast/forms/select/menulist-style-color.html
>> fast/forms/select/select-selected.html
>> fast/forms/select/menulist-width-change.html
>> fast/forms/select/option-text-clip.html
>> fast/forms/select/option-script.html
>> fast/forms/select/option-strip-whitespace.html
>> fast/forms/color/input-appearance-color.html
>> fast/forms/select/select-dirty-parent-pref-widths.html
>> fast/forms/select/select-initial-position.html
>> fast/forms/select/menulist-deselect-update.html
>> fast/forms/select/select-change-listbox-to-popup.html
>> fast/forms/select/select-background-none.html
>> fast/forms/select/menulist-update-text-popup.html
>> fast/forms/select/select-baseline.html
>>
>> Original issue's description:
>> > Don't paint underline or selections over ellipsis in mixed-flow contexts
>> >
>> > Also, ensure the selected text is painted correctly when an ellipsis is
>> present
>> > in a mixed-flow context (e.g. ltr text in an rtl container).
>> >
>> > BUG=642454, 642450, 642460
>> >
>> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:
>> linux_layout_tests_slimming_paint_v2
>> >
>> > Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4
>> > Cr-Commit-Position: refs/heads/master@{#441486}
>>
>> TBR=eae@chromium.org,szager@chromium.org,robhogan@gmail.com
>> # Skipping CQ checks because original CL landed less than 1 days ago.
>> NOPRESUBMIT=true
>> NOTREECHECKS=true
>> NOTRY=true
>> BUG=642454, 642450, 642460
>>
>> Affected files (+17, -371 lines):
>> M third_party/WebKit/LayoutTests/TestExpectations
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping.html
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping-expected.png
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping-expected.txt
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed.html
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping-rtl.html
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed.html
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png
>> D third_party/WebKit/LayoutTests/editing/selection/
>> dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt
>> D third_party/WebKit/LayoutTests/editing/selection/
>> select-text-overflow-ellipsis-mixed-in-ltr-2.html
>> D third_party/WebKit/LayoutTests/editing/selection/
>> select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
>> D third_party/WebKit/LayoutTests/editing/selection/
>> select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt
>> D third_party/WebKit/LayoutTests/editing/selection/
>> select-text-overflow-ellipsis-mixed-in-rtl-2.html
>> D third_party/WebKit/LayoutTests/editing/selection/
>> select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
>> D third_party/WebKit/LayoutTests/editing/selection/
>> select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt
>> D third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-
>> flow-underline-2.html
>> D third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-
>> flow-underline-2-expected.png
>> D third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-
>> flow-underline-2-expected.txt
>> D third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-
>> flow-underline-2.html
>> D third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-
>> flow-underline-2-expected.png
>> D third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-
>> flow-underline-2-expected.txt
>> M third_party/WebKit/LayoutTests/platform/linux/
>> editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
>> M third_party/WebKit/LayoutTests/platform/linux/
>> fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png
>> M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
>> M third_party/WebKit/Source/core/paint/TextPainter.h
>> M third_party/WebKit/Source/core/paint/TextPainter.cpp
>>
>>
>>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[rhogan, 2017-01-05 07:31:27]

Thank you! Those failures don't look like they were caused by my patch. Did
reverting turn the bots green yet?

On Thu, 5 Jan 2017 07:08 Alexey Baskakov, <loyso@chromium.org> wrote:

> This should be visible for everyone:
>
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/1...
>
>
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/1...
>
> On Thu, Jan 5, 2017 at 5:58 PM, Robert Hogan <robhogan@gmail.com> wrote:
>
> This build bot isn't accessible to me. Where can I see the failures that
> caused this roll out?
>
>
> On Thu, 5 Jan 2017 06:24 , <loyso@chromium.org> wrote:
>
> Reviewers: eae, szager1, rhogan
> CL: https://codereview.chromium.org/2615843002/
>
> Message:
> Created Revert of Don't paint underline or selections over ellipsis in
> mixed-flow contexts
>
> Description:
> Revert of Don't paint underline or selections over ellipsis in mixed-flow
> contexts (patchset #3 id:40001 of
> https://codereview.chromium.org/2594983002/ )
>
> Reason for revert:
> Causes test failures on Win10 Win7 bots:
>
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win1...
>
> webkit_tests webkit_tests
>
> unexpected_failures:
> fast/forms/select/menulist-appearance-basic.html
> fast/forms/select/menulist-style-color.html
> fast/forms/select/select-selected.html
> fast/forms/select/menulist-width-change.html
> fast/forms/select/option-text-clip.html
> fast/forms/select/option-script.html
> fast/forms/select/option-strip-whitespace.html
> fast/forms/color/input-appearance-color.html
> fast/forms/select/select-dirty-parent-pref-widths.html
> fast/forms/select/select-initial-position.html
> fast/forms/select/menulist-deselect-update.html
> fast/forms/select/select-change-listbox-to-popup.html
> fast/forms/select/select-background-none.html
> fast/forms/select/menulist-update-text-popup.html
> fast/forms/select/select-baseline.html
>
> Original issue's description:
> > Don't paint underline or selections over ellipsis in mixed-flow contexts
> >
> > Also, ensure the selected text is painted correctly when an ellipsis is
> present
> > in a mixed-flow context (e.g. ltr text in an rtl container).
> >
> > BUG=642454, 642450, 642460
> >
>
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> >
> > Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4
> > Cr-Commit-Position: refs/heads/master@{#441486}
>
> TBR=eae@chromium.org,szager@chromium.org,robhogan@gmail.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=642454, 642450, 642460
>
> Affected files (+17, -371 lines):
> M third_party/WebKit/LayoutTests/TestExpectations
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2.html
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2.html
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt
> M
>
third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
> M
>
third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png
> M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
> M third_party/WebKit/Source/core/paint/TextPainter.h
> M third_party/WebKit/Source/core/paint/TextPainter.cpp
>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[rhogan, 2017-01-05 07:31:39]

Thank you! Those failures don't look like they were caused by my patch. Did
reverting turn the bots green yet?

On Thu, 5 Jan 2017 07:08 Alexey Baskakov, <loyso@chromium.org> wrote:

> This should be visible for everyone:
>
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/1...
>
>
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/1...
>
> On Thu, Jan 5, 2017 at 5:58 PM, Robert Hogan <robhogan@gmail.com> wrote:
>
> This build bot isn't accessible to me. Where can I see the failures that
> caused this roll out?
>
>
> On Thu, 5 Jan 2017 06:24 , <loyso@chromium.org> wrote:
>
> Reviewers: eae, szager1, rhogan
> CL: https://codereview.chromium.org/2615843002/
>
> Message:
> Created Revert of Don't paint underline or selections over ellipsis in
> mixed-flow contexts
>
> Description:
> Revert of Don't paint underline or selections over ellipsis in mixed-flow
> contexts (patchset #3 id:40001 of
> https://codereview.chromium.org/2594983002/ )
>
> Reason for revert:
> Causes test failures on Win10 Win7 bots:
>
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win1...
>
> webkit_tests webkit_tests
>
> unexpected_failures:
> fast/forms/select/menulist-appearance-basic.html
> fast/forms/select/menulist-style-color.html
> fast/forms/select/select-selected.html
> fast/forms/select/menulist-width-change.html
> fast/forms/select/option-text-clip.html
> fast/forms/select/option-script.html
> fast/forms/select/option-strip-whitespace.html
> fast/forms/color/input-appearance-color.html
> fast/forms/select/select-dirty-parent-pref-widths.html
> fast/forms/select/select-initial-position.html
> fast/forms/select/menulist-deselect-update.html
> fast/forms/select/select-change-listbox-to-popup.html
> fast/forms/select/select-background-none.html
> fast/forms/select/menulist-update-text-popup.html
> fast/forms/select/select-baseline.html
>
> Original issue's description:
> > Don't paint underline or selections over ellipsis in mixed-flow contexts
> >
> > Also, ensure the selected text is painted correctly when an ellipsis is
> present
> > in a mixed-flow context (e.g. ltr text in an rtl container).
> >
> > BUG=642454, 642450, 642460
> >
>
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> >
> > Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4
> > Cr-Commit-Position: refs/heads/master@{#441486}
>
> TBR=eae@chromium.org,szager@chromium.org,robhogan@gmail.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=642454, 642450, 642460
>
> Affected files (+17, -371 lines):
> M third_party/WebKit/LayoutTests/TestExpectations
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2.html
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2.html
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt
> M
>
third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
> M
>
third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png
> M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
> M third_party/WebKit/Source/core/paint/TextPainter.h
> M third_party/WebKit/Source/core/paint/TextPainter.cpp
>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[rhogan, 2017-01-05 16:45:25]

Bots are still red by the looks of it. I'll let the dust clear before
relanding my patch.

On Thu, 5 Jan 2017 07:31 Robert Hogan, <robhogan@gmail.com> wrote:

> Thank you! Those failures don't look like they were caused by my patch.
> Did reverting turn the bots green yet?
>
> On Thu, 5 Jan 2017 07:08 Alexey Baskakov, <loyso@chromium.org> wrote:
>
> This should be visible for everyone:
>
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/1...
>
>
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/1...
>
> On Thu, Jan 5, 2017 at 5:58 PM, Robert Hogan <robhogan@gmail.com> wrote:
>
> This build bot isn't accessible to me. Where can I see the failures that
> caused this roll out?
>
>
> On Thu, 5 Jan 2017 06:24 , <loyso@chromium.org> wrote:
>
> Reviewers: eae, szager1, rhogan
> CL: https://codereview.chromium.org/2615843002/
>
> Message:
> Created Revert of Don't paint underline or selections over ellipsis in
> mixed-flow contexts
>
> Description:
> Revert of Don't paint underline or selections over ellipsis in mixed-flow
> contexts (patchset #3 id:40001 of
> https://codereview.chromium.org/2594983002/ )
>
> Reason for revert:
> Causes test failures on Win10 Win7 bots:
>
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win1...
>
> webkit_tests webkit_tests
>
> unexpected_failures:
> fast/forms/select/menulist-appearance-basic.html
> fast/forms/select/menulist-style-color.html
> fast/forms/select/select-selected.html
> fast/forms/select/menulist-width-change.html
> fast/forms/select/option-text-clip.html
> fast/forms/select/option-script.html
> fast/forms/select/option-strip-whitespace.html
> fast/forms/color/input-appearance-color.html
> fast/forms/select/select-dirty-parent-pref-widths.html
> fast/forms/select/select-initial-position.html
> fast/forms/select/menulist-deselect-update.html
> fast/forms/select/select-change-listbox-to-popup.html
> fast/forms/select/select-background-none.html
> fast/forms/select/menulist-update-text-popup.html
> fast/forms/select/select-baseline.html
>
> Original issue's description:
> > Don't paint underline or selections over ellipsis in mixed-flow contexts
> >
> > Also, ensure the selected text is painted correctly when an ellipsis is
> present
> > in a mixed-flow context (e.g. ltr text in an rtl container).
> >
> > BUG=642454, 642450, 642460
> >
>
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> >
> > Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4
> > Cr-Commit-Position: refs/heads/master@{#441486}
>
> TBR=eae@chromium.org,szager@chromium.org,robhogan@gmail.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=642454, 642450, 642460
>
> Affected files (+17, -371 lines):
> M third_party/WebKit/LayoutTests/TestExpectations
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2.html
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2.html
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt
> M
>
third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
> M
>
third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png
> M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
> M third_party/WebKit/Source/core/paint/TextPainter.h
> M third_party/WebKit/Source/core/paint/TextPainter.cpp
>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[rhogan, 2017-01-05 16:45:26]

Bots are still red by the looks of it. I'll let the dust clear before
relanding my patch.

On Thu, 5 Jan 2017 07:31 Robert Hogan, <robhogan@gmail.com> wrote:

> Thank you! Those failures don't look like they were caused by my patch.
> Did reverting turn the bots green yet?
>
> On Thu, 5 Jan 2017 07:08 Alexey Baskakov, <loyso@chromium.org> wrote:
>
> This should be visible for everyone:
>
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/1...
>
>
>
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win10/builds/1...
>
> On Thu, Jan 5, 2017 at 5:58 PM, Robert Hogan <robhogan@gmail.com> wrote:
>
> This build bot isn't accessible to me. Where can I see the failures that
> caused this roll out?
>
>
> On Thu, 5 Jan 2017 06:24 , <loyso@chromium.org> wrote:
>
> Reviewers: eae, szager1, rhogan
> CL: https://codereview.chromium.org/2615843002/
>
> Message:
> Created Revert of Don't paint underline or selections over ellipsis in
> mixed-flow contexts
>
> Description:
> Revert of Don't paint underline or selections over ellipsis in mixed-flow
> contexts (patchset #3 id:40001 of
> https://codereview.chromium.org/2594983002/ )
>
> Reason for revert:
> Causes test failures on Win10 Win7 bots:
>
>
https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Win1...
>
> webkit_tests webkit_tests
>
> unexpected_failures:
> fast/forms/select/menulist-appearance-basic.html
> fast/forms/select/menulist-style-color.html
> fast/forms/select/select-selected.html
> fast/forms/select/menulist-width-change.html
> fast/forms/select/option-text-clip.html
> fast/forms/select/option-script.html
> fast/forms/select/option-strip-whitespace.html
> fast/forms/color/input-appearance-color.html
> fast/forms/select/select-dirty-parent-pref-widths.html
> fast/forms/select/select-initial-position.html
> fast/forms/select/menulist-deselect-update.html
> fast/forms/select/select-change-listbox-to-popup.html
> fast/forms/select/select-background-none.html
> fast/forms/select/menulist-update-text-popup.html
> fast/forms/select/select-baseline.html
>
> Original issue's description:
> > Don't paint underline or selections over ellipsis in mixed-flow contexts
> >
> > Also, ensure the selected text is painted correctly when an ellipsis is
> present
> > in a mixed-flow context (e.g. ltr text in an rtl container).
> >
> > BUG=642454, 642450, 642460
> >
>
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> >
> > Committed: https://crrev.com/8691b058b8f8570128d24b4af3c43b3e2c0151e4
> > Cr-Commit-Position: refs/heads/master@{#441486}
>
> TBR=eae@chromium.org,szager@chromium.org,robhogan@gmail.com
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=642454, 642450, 642460
>
> Affected files (+17, -371 lines):
> M third_party/WebKit/LayoutTests/TestExpectations
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-ltr-mixed-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-mixed-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-2-expected.txt
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2.html
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.png
> D
>
third_party/WebKit/LayoutTests/editing/selection/select-text-overflow-ellipsis-mixed-in-rtl-2-expected.txt
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2.html
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.png
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-2-expected.txt
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2.html
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.png
> D
>
third_party/WebKit/LayoutTests/fast/text/ellipsis-mixed-text-in-rtl-flow-underline-2-expected.txt
> M
>
third_party/WebKit/LayoutTests/platform/linux/editing/selection/select-text-overflow-ellipsis-mixed-in-ltr-expected.png
> M
>
third_party/WebKit/LayoutTests/platform/linux/fast/text/ellipsis-mixed-text-in-ltr-flow-underline-expected.png
> M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp
> M third_party/WebKit/Source/core/paint/TextPainter.h
> M third_party/WebKit/Source/core/paint/TextPainter.cpp
>
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[eae, 2017-01-05 18:15:53]

LGTM post-facto

[rhogan, 2017-01-05 22:47:45]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2611233002/ by robhogan@gmail.com.

The reason for reverting is: This patch was not the culprit for the layout test
failures..

[loyso (OOO), 2017-01-06 02:42:29]

My late apologies. That was a speculative revert, I was wrong. Sorry about that.

[rhogan, 2017-01-06 21:00:02]

No worries, the sheriff has to shoot first and ask questions later!

On Fri, 6 Jan 2017 02:42 , <loyso@chromium.org> wrote:

> My late apologies. That was a speculative revert, I was wrong. Sorry about
> that.
>
> https://codereview.chromium.org/2615843002/
>

-- 
You received this message because you are subscribed to the Google Groups "Blink
Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[rhogan, 2017-01-06 21:00:02]

No worries, the sheriff has to shoot first and ask questions later!

On Fri, 6 Jan 2017 02:42 , <loyso@chromium.org> wrote:

> My late apologies. That was a speculative revert, I was wrong. Sorry about
> that.
>
> https://codereview.chromium.org/2615843002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.