Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 261583004: Object.defineProperty shouldn't be a hint that we're constructing a dictionary. (Closed)

Created:
6 years, 7 months ago by Sven Panne
Modified:
6 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Object.defineProperty shouldn't be a hint that we're constructing a dictionary. BUG=362870 LOG=y R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21109

Patch Set 1 #

Patch Set 2 : Added test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -12 lines) Patch
M src/objects.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M src/runtime.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/runtime.cc View 4 chunks +16 lines, -8 lines 0 comments Download
A test/mjsunit/regress/regress-362870.js View 1 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Sven Panne
6 years, 7 months ago (2014-04-30 11:38:08 UTC) #1
Sven Panne
6 years, 7 months ago (2014-05-02 05:58:45 UTC) #2
Benedikt Meurer
lgtm
6 years, 7 months ago (2014-05-02 06:01:27 UTC) #3
Sven Panne
6 years, 7 months ago (2014-05-02 06:02:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r21109 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698