src/runtime.h - Issue 261583004: Object.defineProperty shouldn't be a hint that we're constructing a dictionary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.h

Issue 261583004: Object.defineProperty shouldn't be a hint that we're constructing a dictionary. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Added test Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.h

diff --git a/src/runtime.h b/src/runtime.h

index eb28f837015ecd1843cd345fcb8f661008d8d36e..a47059d1f78028d84f2740ed6878cf10d2993852 100644

--- a/src/runtime.h

+++ b/src/runtime.h

@@ -819,7 +819,9 @@ class Runtime : public AllStatic {

Handle<JSObject> object,

Handle<Object> key,

Handle<Object> value,

- PropertyAttributes attr);

+ PropertyAttributes attr,

+ JSReceiver::StoreFromKeyed store_from_keyed

+ = JSReceiver::MAY_BE_STORE_FROM_KEYED);

MUST_USE_RESULT static MaybeHandle<Object> DeleteObjectProperty(

Isolate* isolate,

« no previous file with comments | « src/objects.cc ('k') | src/runtime.cc » ('j') | no next file with comments »