Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(992)

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp

Issue 2615813003: Migrate WTF::Vector::append() to ::push_back() [part 14 of N] (Closed)
Patch Set: rebase, small fix in FontSettings.h Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp
index 9158d80eb783abd6c187b069f66368f5424877a9..3ed44c8e77303309e76297c8d8352662a1d7798e 100644
--- a/third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp
+++ b/third_party/WebKit/Source/platform/fonts/shaping/ShapeResult.cpp
@@ -168,7 +168,7 @@ ShapeResult::ShapeResult(const ShapeResult& other)
m_hasVerticalOffsets(other.m_hasVerticalOffsets) {
m_runs.reserveCapacity(other.m_runs.size());
for (const auto& run : other.m_runs)
- m_runs.append(WTF::wrapUnique(new ShapeResult::RunInfo(*run)));
+ m_runs.push_back(WTF::wrapUnique(new ShapeResult::RunInfo(*run)));
}
ShapeResult::~ShapeResult() {}
@@ -371,7 +371,7 @@ void ShapeResult::insertRun(std::unique_ptr<ShapeResult::RunInfo> runToInsert,
}
// If we didn't find an existing slot to place it, append.
if (run)
- m_runs.append(std::move(run));
+ m_runs.push_back(std::move(run));
}
PassRefPtr<ShapeResult> ShapeResult::createForTabulationCharacters(
@@ -403,7 +403,7 @@ PassRefPtr<ShapeResult> ShapeResult::createForTabulationCharacters(
DCHECK_EQ(result->m_numGlyphs, count); // no overflow
result->m_hasVerticalOffsets =
fontData->platformData().isVerticalAnyUpright();
- result->m_runs.append(std::move(run));
+ result->m_runs.push_back(std::move(run));
return result.release();
}

Powered by Google App Engine
This is Rietveld 408576698