[Extensions Bindings] Add enum support

[Extensions Bindings] Add enum support

We expose API enums on objects with in the API; this is mostly useful
because our enum style is pretty wildly inconsistent (hacker_style,
camelCase, and SCREAMING_STYLE are all used). This allows authors to
use the enum directly by using chrome.foo.BarEnum.SOMETHING.

Add support for this in native bindings.

BUG=653596
Review-Url: https://codereview.chromium.org/2615773002
Cr-Commit-Position: refs/heads/master@{#442082}
Committed: https://chromium.googlesource.com/chromium/src/+/e91bd78f8794bcd4bac686120da2932fc5f5e8b1

[Devlin, 2017-01-04 23:39:42]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 23:40:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-04 23:56:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 23:56:49]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2017-01-05 18:06:32]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 18:07:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 19:09:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 19:09:46]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-01-05 19:18:50]

rdevlin.cronin@chromium.org changed reviewers:
+ jbroman@chromium.org, lazyboy@chromium.org

[jbroman, 2017-01-05 22:31:24]

lgtm

https://codereview.chromium.org/2615773002/diff/40001/extensions/renderer/api...
File extensions/renderer/api_binding.cc (right):

https://codereview.chromium.org/2615773002/diff/40001/extensions/renderer/api...
extensions/renderer/api_binding.cc:215: for (const auto& entry : enums_) {
This seems like it would be very easy to stamp out of an ObjectTemplate in the
future.

[lazyboy, 2017-01-05 23:09:13]

lgtm

https://codereview.chromium.org/2615773002/diff/40001/extensions/renderer/api...
File extensions/renderer/api_binding.cc (right):

https://codereview.chromium.org/2615773002/diff/40001/extensions/renderer/api...
extensions/renderer/api_binding.cc:32: if (base::IsAsciiDigit(original[0]))
DCHECK(!original.empty())
CHECK might be too expensive for a silly case like this, therefore DCHECK.

[Devlin, 2017-01-06 21:12:54]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-06 21:13:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 21:39:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-06 21:39:02]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Devlin, 2017-01-06 22:33:42]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2017-01-06 22:33:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
lazyboy@chromium.org, jbroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2615773002/#ps80001
(title: "nits")

[Devlin, 2017-01-06 22:33:52]

https://codereview.chromium.org/2615773002/diff/40001/extensions/renderer/api...
File extensions/renderer/api_binding.cc (right):

https://codereview.chromium.org/2615773002/diff/40001/extensions/renderer/api...
extensions/renderer/api_binding.cc:32: if (base::IsAsciiDigit(original[0]))
On 2017/01/05 23:09:13, lazyboy wrote:
> DCHECK(!original.empty())
> CHECK might be too expensive for a silly case like this, therefore DCHECK.

Done.

https://codereview.chromium.org/2615773002/diff/40001/extensions/renderer/api...
extensions/renderer/api_binding.cc:215: for (const auto& entry : enums_) {
On 2017/01/05 22:31:24, jbroman wrote:
> This seems like it would be very easy to stamp out of an ObjectTemplate in the
> future.

Good point.  Added a TODO

[commit-bot: I haz the power, 2017-01-06 22:34:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-06 22:47:52]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1483742022920640,
"parent_rev": "50252de90c71b7d5d12c30121a82d4e790f74252", "commit_rev":
"e91bd78f8794bcd4bac686120da2932fc5f5e8b1"}

[commit-bot: I haz the power, 2017-01-06 22:48:19]

Description was changed from

==========
[Extensions Bindings] Add enum support

We expose API enums on objects with in the API; this is mostly useful
because our enum style is pretty wildly inconsistent (hacker_style,
camelCase, and SCREAMING_STYLE are all used). This allows authors to
use the enum directly by using chrome.foo.BarEnum.SOMETHING.

Add support for this in native bindings.

BUG=653596
==========

to

==========
[Extensions Bindings] Add enum support

We expose API enums on objects with in the API; this is mostly useful
because our enum style is pretty wildly inconsistent (hacker_style,
camelCase, and SCREAMING_STYLE are all used). This allows authors to
use the enum directly by using chrome.foo.BarEnum.SOMETHING.

Add support for this in native bindings.

BUG=653596

Review-Url: https://codereview.chromium.org/2615773002
Cr-Commit-Position: refs/heads/master@{#442082}
Committed:
https://chromium.googlesource.com/chromium/src/+/e91bd78f8794bcd4bac686120da2...
==========

[commit-bot: I haz the power, 2017-01-06 22:48:20]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/e91bd78f8794bcd4bac686120da2...