Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2615763002: Revert of Supporting study definitions without default groups and end_date filtering. (Closed)

Created:
3 years, 11 months ago by Devlin
Modified:
3 years, 11 months ago
Reviewers:
rkaplow, jwd
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Supporting study definitions without default groups and end_date filtering. (patchset #2 id:80001 of https://codereview.chromium.org/2614443002/ ) Reason for revert: Sheriff: Broke sizes on linux (see comment in CL) Original issue's description: > Supporting study definitions without default groups and end_date filtering. > > end_date is a replacement for expiry_date, which is deprecated by this change. The difference is that end_date is acts as a normal filter, and causes study to not be created when the date is past. expiry_date caused the study to be created, and forced to the default group. > > This change introduces a generic default group name, which is used for the field trial API when a study doesn't specify one. > > BUG=677976 > > Committed: https://crrev.com/49d24a0cc2a73773f3ee72b4d242d6fad8c57254 > Cr-Commit-Position: refs/heads/master@{#441487} TBR=rkaplow@chromium.org,jwd@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=677976 Committed: https://crrev.com/582227f037556baea1e228ced47eefed03758cb1 Cr-Commit-Position: refs/heads/master@{#441504}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -105 lines) Patch
M components/variations/processed_study.h View 2 chunks +0 lines, -8 lines 0 comments Download
M components/variations/processed_study.cc View 4 chunks +8 lines, -16 lines 0 comments Download
M components/variations/proto/study.proto View 3 chunks +2 lines, -13 lines 0 comments Download
M components/variations/study_filtering.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/variations/study_filtering.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M components/variations/study_filtering_unittest.cc View 3 chunks +4 lines, -30 lines 0 comments Download
M components/variations/variations_seed_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/variations/variations_seed_processor_unittest.cc View 2 chunks +1 line, -19 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Devlin
Created Revert of Supporting study definitions without default groups and end_date filtering.
3 years, 11 months ago (2017-01-04 23:14:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615763002/1
3 years, 11 months ago (2017-01-04 23:14:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 11 months ago (2017-01-04 23:15:53 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 23:19:09 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/582227f037556baea1e228ced47eefed03758cb1
Cr-Commit-Position: refs/heads/master@{#441504}

Powered by Google App Engine
This is Rietveld 408576698