Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2615753005: [Contextual Search] Add background color to quick action ImageView (Closed)

Created:
3 years, 11 months ago by Theresa
Modified:
3 years, 11 months ago
Reviewers:
Donn Denman
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Contextual Search] Add background color to quick action ImageView ViewResourceAdapter re-uses bitmaps where possible. The app icons drawn into the quick action ImageView have transparent backgrounds, so when the bitmap is re-used some of pixels do not get re-drawn making it look like two app icons are layered on top of each other. Setting a background on the quick action ImageView causes all pixels to get redrawn when the bitmap is captured. BUG=678708 Review-Url: https://codereview.chromium.org/2615753005 Cr-Commit-Position: refs/heads/master@{#441852} Committed: https://chromium.googlesource.com/chromium/src/+/5ec4db1337f3b37ec09824e8b12a1051646098be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/android/java/res/layout/contextual_search_quick_action_icon_view.xml View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (9 generated)
Theresa
ptal
3 years, 11 months ago (2017-01-05 22:45:07 UTC) #2
Donn Denman
lgtm
3 years, 11 months ago (2017-01-06 00:24:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615753005/1
3 years, 11 months ago (2017-01-06 00:25:25 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 02:52:32 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5ec4db1337f3b37ec09824e8b12a...

Powered by Google App Engine
This is Rietveld 408576698