Android: Stop including unsupport locales in resources.arsc

Android: Stop including unsupport locales in resources.arsc

They were being pulled in from dependent libraries. We now pass an
explicit whitelist to aapt to ensure only support locales are being
included.

This shaves 470kb off of ChromePublic.apk, 100kb of which
was recently added by the gvr library in bug 678309.

The list of removed configs (via aapt dump configurations):
af
az
az-rAZ
be-rBY
bn
bn-rBD
bs-rBA
en-rAU
en-rIN
es-r419
et
et-rEE
eu-rES
fr-rCA
gl
gl-rES
gu
gu-rIN
hy-rAM
is
is-rIS
ka
ka-rGE
kk
kk-rKZ
km
km-rKH
kn
kn-rIN
ky
ky-rKG
lo
lo-rLA
mk-rMK
ml
ml-rIN
mn
mn-rMN
mr
mr-rIN
ms
ms-rMY
my
my-rMM
ne
ne-rNP
no
pa
pa-rIN
si-rLK
sq-rAL
ta-rIN
te
te-rIN
tl
ur-rPK
uz
uz-rUZ
zh-rHK
zu

BUG=678628, 678309
Review-Url: https://codereview.chromium.org/2615753004
Cr-Commit-Position: refs/heads/master@{#442907}
Committed: https://chromium.googlesource.com/chromium/src/+/87f1b6b8f0e0493ba7d1540abe795e13b313e141

[agrieve, 2017-01-05 16:04:04]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-05 16:04:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agrieve, 2017-01-05 16:04:58]

Description was changed from

==========
Android: Stop including unsupport locales in resources.arsc

They were being pulled in from dependent libraries. We now pass an
explicit whitelist to aapt to ensure only support locales are being
included.

This shaves over 600kb off of ChromePublic.apk.

BUG=678628
==========

to

==========
Android: Stop including unsupport locales in resources.arsc

They were being pulled in from dependent libraries. We now pass an
explicit whitelist to aapt to ensure only support locales are being
included.

This shaves over 600kb off of ChromePublic.apk, 100kb of which
was recently added by the gvr library in bug 678309.

BUG=678628,678309
==========

[agrieve, 2017-01-05 16:04:59]

agrieve@chromium.org changed reviewers:
+ bshe@chromium.org, michaelbai@chromium.org

[commit-bot: I haz the power, 2017-01-05 16:56:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 16:56:24]

Dry run: This issue passed the CQ dry run.

[agrieve, 2017-01-05 18:29:50]

On 2017/01/05 16:56:24, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

Actually, I'm pretty sure this is stripping out some valid translations, since
it should actaully be merging "en-rUS" with "en" rather than selecting only
"en"... Please hold off.

[agrieve, 2017-01-05 20:27:20]

Description was changed from

==========
Android: Stop including unsupport locales in resources.arsc

They were being pulled in from dependent libraries. We now pass an
explicit whitelist to aapt to ensure only support locales are being
included.

This shaves over 600kb off of ChromePublic.apk, 100kb of which
was recently added by the gvr library in bug 678309.

BUG=678628,678309
==========

to

==========
Android: Stop including unsupport locales in resources.arsc

They were being pulled in from dependent libraries. We now pass an
explicit whitelist to aapt to ensure only support locales are being
included.

This shaves 470kb off of ChromePublic.apk, 100kb of which
was recently added by the gvr library in bug 678309.

The list of removed configs (via aapt dump configurations):
af
az
az-rAZ
be-rBY
bn
bn-rBD
bs-rBA
en-rAU
en-rIN
es-r419
et
et-rEE
eu-rES
fr-rCA
gl
gl-rES
gu
gu-rIN
hy-rAM
is
is-rIS
ka
ka-rGE
kk
kk-rKZ
km
km-rKH
kn
kn-rIN
ky
ky-rKG
lo
lo-rLA
mk-rMK
ml
ml-rIN
mn
mn-rMN
mr
mr-rIN
ms
ms-rMY
my
my-rMM
ne
ne-rNP
no
pa
pa-rIN
si-rLK
sq-rAL
ta-rIN
te
te-rIN
tl
ur-rPK
uz
uz-rUZ
zh-rHK
zu

BUG=678628,678309
==========

[agrieve, 2017-01-05 20:31:29]

On 2017/01/05 18:29:50, agrieve wrote:
> On 2017/01/05 16:56:24, commit-bot: I haz the power wrote:
> > Dry run: This issue passed the CQ dry run.
> 
> Actually, I'm pretty sure this is stripping out some valid translations, since
> it should actaully be merging "en-rUS" with "en" rather than selecting only
> "en"... Please hold off.

okay, should be good to go. Still shaves off 470kb.

[bshe, 2017-01-05 20:56:07]

On 2017/01/05 20:31:29, agrieve wrote:
> On 2017/01/05 18:29:50, agrieve wrote:
> > On 2017/01/05 16:56:24, commit-bot: I haz the power wrote:
> > > Dry run: This issue passed the CQ dry run.
> > 
> > Actually, I'm pretty sure this is stripping out some valid translations,
since
> > it should actaully be merging "en-rUS" with "en" rather than selecting only
> > "en"... Please hold off.
> 
> okay, should be good to go. Still shaves off 470kb.

my review probably wont be enough. But thanks for fixing it!
lgtm

[michaelbai, 2017-01-05 22:41:40]

https://codereview.chromium.org/2615753004/diff/20001/chrome/android/chrome_p...
File chrome/android/chrome_public_apk_tmpl.gni (right):

https://codereview.chromium.org/2615753004/diff/20001/chrome/android/chrome_p...
chrome/android/chrome_public_apk_tmpl.gni:45: aapt_locale_whitelist = locales -
android_chrome_omitted_locales
Did this remove the locales supported by WebView in monochrome?

[agrieve, 2017-01-06 01:51:30]

On 2017/01/05 22:41:40, michaelbai wrote:
>
https://codereview.chromium.org/2615753004/diff/20001/chrome/android/chrome_p...
> File chrome/android/chrome_public_apk_tmpl.gni (right):
> 
>
https://codereview.chromium.org/2615753004/diff/20001/chrome/android/chrome_p...
> chrome/android/chrome_public_apk_tmpl.gni:45: aapt_locale_whitelist = locales
-
> android_chrome_omitted_locales
> Did this remove the locales supported by WebView in monochrome?

Good catch! I forgot webview supported all of them. I've updated it so that
webview & monochrome set the whitelist to "locales".

[michaelbai, 2017-01-11 01:08:10]

LGTM

[agrieve, 2017-01-11 02:27:59]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 02:28:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 04:25:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 04:26:00]

Dry run: This issue passed the CQ dry run.

[agrieve, 2017-01-11 15:08:31]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2017-01-11 15:08:31]

The patchset sent to the CQ was uploaded after l-g-t-m from bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/2615753004/#ps40001
(title: "Make monochrome include all locales")

[commit-bot: I haz the power, 2017-01-11 15:08:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-11 15:14:57]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484147311352690,
"parent_rev": "c3fd406f53369c1714d3587087146ff6ead4adab", "commit_rev":
"87f1b6b8f0e0493ba7d1540abe795e13b313e141"}

[commit-bot: I haz the power, 2017-01-11 15:15:23]

Description was changed from

==========
Android: Stop including unsupport locales in resources.arsc

They were being pulled in from dependent libraries. We now pass an
explicit whitelist to aapt to ensure only support locales are being
included.

This shaves 470kb off of ChromePublic.apk, 100kb of which
was recently added by the gvr library in bug 678309.

The list of removed configs (via aapt dump configurations):
af
az
az-rAZ
be-rBY
bn
bn-rBD
bs-rBA
en-rAU
en-rIN
es-r419
et
et-rEE
eu-rES
fr-rCA
gl
gl-rES
gu
gu-rIN
hy-rAM
is
is-rIS
ka
ka-rGE
kk
kk-rKZ
km
km-rKH
kn
kn-rIN
ky
ky-rKG
lo
lo-rLA
mk-rMK
ml
ml-rIN
mn
mn-rMN
mr
mr-rIN
ms
ms-rMY
my
my-rMM
ne
ne-rNP
no
pa
pa-rIN
si-rLK
sq-rAL
ta-rIN
te
te-rIN
tl
ur-rPK
uz
uz-rUZ
zh-rHK
zu

BUG=678628,678309
==========

to

==========
Android: Stop including unsupport locales in resources.arsc

They were being pulled in from dependent libraries. We now pass an
explicit whitelist to aapt to ensure only support locales are being
included.

This shaves 470kb off of ChromePublic.apk, 100kb of which
was recently added by the gvr library in bug 678309.

The list of removed configs (via aapt dump configurations):
af
az
az-rAZ
be-rBY
bn
bn-rBD
bs-rBA
en-rAU
en-rIN
es-r419
et
et-rEE
eu-rES
fr-rCA
gl
gl-rES
gu
gu-rIN
hy-rAM
is
is-rIS
ka
ka-rGE
kk
kk-rKZ
km
km-rKH
kn
kn-rIN
ky
ky-rKG
lo
lo-rLA
mk-rMK
ml
ml-rIN
mn
mn-rMN
mr
mr-rIN
ms
ms-rMY
my
my-rMM
ne
ne-rNP
no
pa
pa-rIN
si-rLK
sq-rAL
ta-rIN
te
te-rIN
tl
ur-rPK
uz
uz-rUZ
zh-rHK
zu

BUG=678628,678309

Review-Url: https://codereview.chromium.org/2615753004
Cr-Commit-Position: refs/heads/master@{#442907}
Committed:
https://chromium.googlesource.com/chromium/src/+/87f1b6b8f0e0493ba7d1540abe79...
==========

[commit-bot: I haz the power, 2017-01-11 15:15:26]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/87f1b6b8f0e0493ba7d1540abe79...