Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: google_apis/gcm/engine/checkin_request_unittest.cc

Issue 261573002: Add checkin activity recording to gcm recorder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing jian's comments. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/gcm/engine/checkin_request_unittest.cc
diff --git a/google_apis/gcm/engine/checkin_request_unittest.cc b/google_apis/gcm/engine/checkin_request_unittest.cc
index e750df077cbe9ce218e08f57649c4a583b22c495..62cd7afc3612e1f1430fc2b4d5f82b1f44491500 100644
--- a/google_apis/gcm/engine/checkin_request_unittest.cc
+++ b/google_apis/gcm/engine/checkin_request_unittest.cc
@@ -6,6 +6,7 @@
#include <vector>
#include "google_apis/gcm/engine/checkin_request.h"
+#include "google_apis/gcm/monitoring/gcm_stats_recorder.h"
#include "google_apis/gcm/protocol/checkin.pb.h"
#include "net/base/backoff_entry.h"
#include "net/url_request/test_url_fetcher_factory.h"
@@ -90,6 +91,7 @@ class CheckinRequestTest : public testing::Test {
checkin_proto::ChromeBuildProto chrome_build_proto_;
std::vector<std::string> account_ids_;
scoped_ptr<CheckinRequest> request_;
+ GCMStatsRecorder recorder_;
};
CheckinRequestTest::CheckinRequestTest()
@@ -134,7 +136,8 @@ void CheckinRequestTest::CreateRequest(uint64 android_id,
request_info,
kDefaultBackoffPolicy,
base::Bind(&CheckinRequestTest::FetcherCallback, base::Unretained(this)),
- url_request_context_getter_.get()));
+ url_request_context_getter_.get(),
+ &recorder_));
// Setting android_id_ and security_token_ to blank value, not used elsewhere
// in the tests.

Powered by Google App Engine
This is Rietveld 408576698