google_apis/gcm/gcm_client_impl.cc - Issue 261573002: Add checkin activity recording to gcm recorder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/gcm_client_impl.cc

Issue 261573002: Add checkin activity recording to gcm recorder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing jian's comments. Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: google_apis/gcm/gcm_client_impl.cc

diff --git a/google_apis/gcm/gcm_client_impl.cc b/google_apis/gcm/gcm_client_impl.cc

index 46295bd18f19c4597093b5f8abbf7a0a8c4da1c3..b6a857885116d94f9fdd571fed14d11231d76bfb 100644

--- a/google_apis/gcm/gcm_client_impl.cc

+++ b/google_apis/gcm/gcm_client_impl.cc

@@ -305,7 +305,8 @@ void GCMClientImpl::StartCheckin() {

kDefaultBackoffPolicy,

base::Bind(&GCMClientImpl::OnCheckinCompleted,

weak_ptr_factory_.GetWeakPtr()),

- url_request_context_getter_));

+ url_request_context_getter_,

+ &recorder_));

checkin_request_->Start();

}