Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2615723002: Revert of Fix leak in VRServiceImpl (Closed)

Created:
3 years, 11 months ago by mthiesse
Modified:
3 years, 11 months ago
Reviewers:
brettw, bshe
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Revert of Fix leak in VRServiceImpl (patchset #2 id:20001 of https://codereview.chromium.org/2590883003/ ) Reason for revert: Causes crash on Chrome Beta 56.0.2924.51 Original issue's description: > Fix leak in VRServiceImpl > > This makes the implicit Strong Binding between the service and clients explicit, and fixes the service leaking when the binding is closed. > > No functional changes here. > > BUG=651245 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation > TBR=brettw@chromium.org > > Review-Url: https://codereview.chromium.org/2571323002 > Cr-Commit-Position: refs/heads/master@{#439333} > (cherry picked from commit 7980a0e0ca7f5a6abda7e57ab28fbf8f845bfbf8) > > Committed: https://chromium.googlesource.com/chromium/src/+/225bb8d94ed0a406519a9935c6577a2855aafed1 TBR=brettw@chromium.org,bshe@chromium.org NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=651245 Review-Url: https://codereview.chromium.org/2615723002

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -13 lines) Patch
M content/browser/frame_host/render_frame_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/vr/vr_display_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M device/vr/vr_service_impl.h View 3 chunks +10 lines, -3 lines 0 comments Download
M device/vr/vr_service_impl.cc View 1 chunk +19 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (9 generated)
mthiesse
Created Revert of Fix leak in VRServiceImpl
3 years, 11 months ago (2017-01-04 21:20:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615723002/1
3 years, 11 months ago (2017-01-04 21:23:31 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-04 21:28:29 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698