Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2615713008: Revert of componentize SafeBrowsingService (Closed)

Created:
3 years, 11 months ago by Nate Fischer
Modified:
3 years, 11 months ago
Reviewers:
sgurun-gerrit only
CC:
blundell+watchlist_chromium.org, chromium-reviews, droger+watchlist_chromium.org, grt+watch_chromium.org, sdefresne+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of componentize SafeBrowsingService (patchset #6 id:100001 of https://codereview.chromium.org/2605213002/ ) Reason for revert: We've decided to not componentize SafeBrowsingService and instead manually create the DataBaseManager and UIManager Original issue's description: > componentize SafeBrowsingService > > Create BaseSafeBrowsingService in the components layer and derive > SafeBrowsingService from that. > > BUG=488675 > > Committed: https://crrev.com/e5f4a58871b512092e37080597014271bbb8fbc6 > Cr-Commit-Position: refs/heads/master@{#441305} TBR=jialiul@chromium.org,mmenke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=488675 Review-Url: https://codereview.chromium.org/2615713008 Cr-Commit-Position: refs/heads/master@{#442139} Committed: https://chromium.googlesource.com/chromium/src/+/cf94fed75deefdaf732436650001839958118056

Patch Set 1 #

Patch Set 2 : Revert BaseSafeBrowsingService and fix conflicts #

Patch Set 3 : Removing more gn deps #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -204 lines) Patch
M chrome/browser/safe_browsing/safe_browsing_service.h View 1 8 chunks +25 lines, -8 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 1 3 chunks +1 line, -4 lines 0 comments Download
M components/safe_browsing/BUILD.gn View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M components/safe_browsing/DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
D components/safe_browsing/base_safe_browsing_service.h View 1 chunk +0 lines, -104 lines 0 comments Download
D components/safe_browsing/base_safe_browsing_service.cc View 1 chunk +0 lines, -80 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Nate Fischer
Created Revert of componentize SafeBrowsingService
3 years, 11 months ago (2017-01-06 22:58:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615713008/1
3 years, 11 months ago (2017-01-06 22:58:53 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-06 22:58:54 UTC) #5
Nate Fischer
sgurun@: can you PTAL?
3 years, 11 months ago (2017-01-06 23:01:11 UTC) #7
sgurun-gerrit only
On 2017/01/06 23:01:11, Nate Fischer wrote: > sgurun@: can you PTAL? lgtm you can tbr ...
3 years, 11 months ago (2017-01-06 23:02:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615713008/1
3 years, 11 months ago (2017-01-06 23:02:33 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/131723) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-06 23:04:25 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615713008/170001
3 years, 11 months ago (2017-01-07 00:30:58 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-07 02:10:27 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:170001) as
https://chromium.googlesource.com/chromium/src/+/cf94fed75deefdaf732436650001...

Powered by Google App Engine
This is Rietveld 408576698