Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2615713006: Use a new Supplement constructor in DeviceOrientationController's hierarchy (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews, haraken, mlamouri+watch-blink_chromium.org, timvolodine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a new Supplement constructor in DeviceOrientationController's hierarchy We're deprecating the default constructor of Supplement. BUG=610176 Review-Url: https://codereview.chromium.org/2615713006 Cr-Commit-Position: refs/heads/master@{#441920} Committed: https://chromium.googlesource.com/chromium/src/+/5251d861c9ec23ba5d3205582b7904eac64f3d1b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/device_light/DeviceLightController.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceMotionController.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceOrientationController.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
haraken
PTAL
3 years, 11 months ago (2017-01-06 09:47:15 UTC) #3
haraken
PTAL
3 years, 11 months ago (2017-01-06 09:47:16 UTC) #4
sof
lgtm
3 years, 11 months ago (2017-01-06 10:06:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615713006/1
3 years, 11 months ago (2017-01-06 10:13:12 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 11:25:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5251d861c9ec23ba5d3205582b79...

Powered by Google App Engine
This is Rietveld 408576698