[MD WebUI] Move icons used in Bookmarks and Settings to shared file.

[MD WebUI] Move icons used in Bookmarks and Settings to shared file.

This CL moves everything in icons.html from bookmarks and settings to
cr_elements/icons.html and updates the related files using it.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2615673003
Cr-Commit-Position: refs/heads/master@{#442525}
Committed: https://chromium.googlesource.com/chromium/src/+/236b242417b64ccb62084dd6a6b63f50074b9897

[jiaxi, 2017-01-05 04:33:36]

Description was changed from

==========
[MD WebUI] Put Icons to a Shared File for Bookmarks and Settings.

This CL moves everything in icons.html from bookmarks and settings to
cr_elements/icons.html and updates the related files using it.

BUG=651980
==========

to

==========
[MD WebUI] Put Icons to a Shared File for Bookmarks and Settings.

This CL moves everything in icons.html from bookmarks and settings to
cr_elements/icons.html and updates the related files using it.

BUG=651980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jiaxi, 2017-01-05 04:40:18]

Patchset #1 (id:1) has been deleted

[jiaxi, 2017-01-05 04:44:38]

Patchset #1 (id:20001) has been deleted

[jiaxi, 2017-01-05 04:47:39]

jiaxi@google.com changed reviewers:
+ angelayang@google.com, calamity@chromium.org, tsergeant@chromium.org

[jiaxi, 2017-01-05 04:47:40]

https://codereview.chromium.org/2615673003/diff/40001/chrome/browser/resource...
File chrome/browser/resources/settings/icons.html (left):

https://codereview.chromium.org/2615673003/diff/40001/chrome/browser/resource...
chrome/browser/resources/settings/icons.html:8: <g id="cookie">
There are some icons in this file that haven't been used in settings yet. These
are:
battery-charging-full
brightness-1
cloud
code
conten-copy
refresh
rotate-right
supervisor-account
volume-up

Atm I just moved everything in this file to cr_element, Dan do you want me to
clean these up or you'll need them later?

[calamity, 2017-01-05 06:42:54]

Sorry for not being more clear, we only want to move the shared elements
(arrow-drop-up and folder). Everything else should stay as it is.

[jiaxi, 2017-01-05 23:28:23]

Patchset #2 (id:60001) has been deleted

[jiaxi, 2017-01-05 23:30:16]

On 2017/01/05 06:42:54, calamity wrote:
> Sorry for not being more clear, we only want to move the shared elements
> (arrow-drop-up and folder). Everything else should stay as it is.

I've revert most of the stuff :)

[tsergeant, 2017-01-06 00:23:40]

https://codereview.chromium.org/2615673003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/item.html (left):

https://codereview.chromium.org/2615673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/item.html:3: <link rel="import"
href="chrome://resources/html/icon.html">
I think this import is still necessary for the call to `cr.icon` to get the
favicon

[tsergeant, 2017-01-06 00:30:46]

Also, small grammar suggestion for the CL description:

[MD WebUI] Move icons used in Bookmarks and Settings to shared file

[jiaxi, 2017-01-06 03:54:30]

Description was changed from

==========
[MD WebUI] Put Icons to a Shared File for Bookmarks and Settings.

This CL moves everything in icons.html from bookmarks and settings to
cr_elements/icons.html and updates the related files using it.

BUG=651980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD WebUI] Move icons used in Bookmarks and Settings to shared file.

This CL moves everything in icons.html from bookmarks and settings to
cr_elements/icons.html and updates the related files using it.

BUG=651980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[jiaxi, 2017-01-06 03:56:17]

https://codereview.chromium.org/2615673003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/item.html (left):

https://codereview.chromium.org/2615673003/diff/80001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/item.html:3: <link rel="import"
href="chrome://resources/html/icon.html">
On 2017/01/06 00:23:40, tsergeant wrote:
> I think this import is still necessary for the call to `cr.icon` to get the
> favicon

Done.

[calamity, 2017-01-06 04:25:07]

lgtm

[tsergeant, 2017-01-08 23:27:03]

lgtm

[jiaxi, 2017-01-08 23:55:27]

jiaxi@google.com changed reviewers:
+ dbeam@chromium.org

[jiaxi, 2017-01-08 23:56:19]

Hey Dan,

I've moved some shared icons to the cr-icons page. Please take a look!

[Dan Beam, 2017-01-10 01:25:11]

lgtm

[jiaxi, 2017-01-10 05:35:57]

The CQ bit was checked by jiaxi@google.com

[jiaxi, 2017-01-10 05:35:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
tsergeant@chromium.org, calamity@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2615673003/#ps120001
(title: "merge")

[commit-bot: I haz the power, 2017-01-10 05:36:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-10 07:34:44]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1484026557636830,
"parent_rev": "7a7dee0d2d921c83a17984b143d8b1988f49c93a", "commit_rev":
"236b242417b64ccb62084dd6a6b63f50074b9897"}

[commit-bot: I haz the power, 2017-01-10 07:35:17]

Description was changed from

==========
[MD WebUI] Move icons used in Bookmarks and Settings to shared file.

This CL moves everything in icons.html from bookmarks and settings to
cr_elements/icons.html and updates the related files using it.

BUG=651980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD WebUI] Move icons used in Bookmarks and Settings to shared file.

This CL moves everything in icons.html from bookmarks and settings to
cr_elements/icons.html and updates the related files using it.

BUG=651980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2615673003
Cr-Commit-Position: refs/heads/master@{#442525}
Committed:
https://chromium.googlesource.com/chromium/src/+/236b242417b64ccb62084dd6a6b6...
==========

[commit-bot: I haz the power, 2017-01-10 07:35:18]

Committed patchset #4 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/236b242417b64ccb62084dd6a6b6...

[lfg, 2017-01-10 16:52:55]

Just FYI, You've been using the wrong bug number for your last 6 CLs.

[jiaxi, 2017-01-10 23:05:02]

Description was changed from

==========
[MD WebUI] Move icons used in Bookmarks and Settings to shared file.

This CL moves everything in icons.html from bookmarks and settings to
cr_elements/icons.html and updates the related files using it.

BUG=651980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2615673003
Cr-Commit-Position: refs/heads/master@{#442525}
Committed:
https://chromium.googlesource.com/chromium/src/+/236b242417b64ccb62084dd6a6b6...
==========

to

==========
[MD WebUI] Move icons used in Bookmarks and Settings to shared file.

This CL moves everything in icons.html from bookmarks and settings to
cr_elements/icons.html and updates the related files using it.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2615673003
Cr-Commit-Position: refs/heads/master@{#442525}
Committed:
https://chromium.googlesource.com/chromium/src/+/236b242417b64ccb62084dd6a6b6...
==========