Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: third_party/WebKit/Source/core/dom/DOMQuad.idl

Issue 2615653003: [GeometryInterface] Implement DOMQuad and DOMQuadInit. (Closed)
Patch Set: [GeometryInterface] Implement DOMQuad and DOMQuadInit. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/DOMQuad.idl
diff --git a/third_party/WebKit/Source/core/dom/DOMQuad.idl b/third_party/WebKit/Source/core/dom/DOMQuad.idl
new file mode 100644
index 0000000000000000000000000000000000000000..912bff39512cd0b0e94d9f995485923283d37f57
--- /dev/null
+++ b/third_party/WebKit/Source/core/dom/DOMQuad.idl
@@ -0,0 +1,24 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// https://drafts.fxtf.org/geometry/#domquad
+
zino 2017/01/08 17:52:30 nit: unnecessary blank line?
Hwanseung Lee 2017/01/09 13:28:24 Done.
+
+[
+ Constructor(optional DOMPointInit p1, optional DOMPointInit p2,
+ optional DOMPointInit p3, optional DOMPointInit p4),
zino 2017/01/08 17:52:30 It's better to align with the line just above.
Hwanseung Lee 2017/01/09 13:28:24 Done.
+ // FIXME: Exposed=(Window,Worker),
zino 2017/01/08 17:52:30 Why do you leave FIXME comment here?
Hwanseung Lee 2017/01/09 13:28:24 i will remove comment after implement all function
+ RuntimeEnabled=GeometryInterfaces,
+] interface DOMQuad {
+ // FIXME: [NewObject] static DOMQuad fromRect(optional DOMRectInit other);
zino 2017/01/08 17:52:30 According to coding style guide, we should use TOD
Hwanseung Lee 2017/01/09 13:28:24 Done.
+ // FIXME: [NewObject] static DOMQuad fromQuad(optional DOMQuadInit other);
+
+ [SameObject] readonly attribute DOMPoint p1;
+ [SameObject] readonly attribute DOMPoint p2;
+ [SameObject] readonly attribute DOMPoint p3;
+ [SameObject] readonly attribute DOMPoint p4;
+ // FIXME: [NewObject] DOMRect getBounds();
+
+ // FIXME: serializer = { attribute };
+};

Powered by Google App Engine
This is Rietveld 408576698