[wrapper-tracing] Enhance verifier output

[wrapper-tracing] Enhance verifier output

ScriptWrappableVisitorVerifier will now put a callback containing the type that
missed the write barrier on the stacktrace.

BUG=468240, 678016

[Michael Lippautz, 2017-01-04 16:05:13]

Description was changed from

==========
[wrapper-tracing] Enhance verifier output

ScriptWrappableVisitorVerifier will now put a callback containing the type that
missed the write barrier on the stacktrace.

BUG=
==========

to

==========
[wrapper-tracing] Enhance verifier output

ScriptWrappableVisitorVerifier will now put a callback containing the type that
missed the write barrier on the stacktrace.

BUG=468240
==========

[Michael Lippautz, 2017-01-04 16:05:13]

mlippautz@chromium.org changed reviewers:
+ haraken@chromium.org, hlopko@chromium.org

[Michael Lippautz, 2017-01-04 16:05:46]

ptal

I failed to move WrapperMarkingData to WrapperVisitor.h, so I am taking this
approach for now.

[Michael Lippautz, 2017-01-04 16:06:04]

Description was changed from

==========
[wrapper-tracing] Enhance verifier output

ScriptWrappableVisitorVerifier will now put a callback containing the type that
missed the write barrier on the stacktrace.

BUG=468240
==========

to

==========
[wrapper-tracing] Enhance verifier output

ScriptWrappableVisitorVerifier will now put a callback containing the type that
missed the write barrier on the stacktrace.

BUG=468240,678016
==========

[Michael Lippautz, 2017-01-04 16:06:11]

The CQ bit was checked by mlippautz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-04 16:06:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Lippautz, 2017-01-04 16:22:06]

(Since polymorphism and templates doesn't really like each other, the only way
to really solve this is use CRTP.)

[Marcel Hlopko, 2017-01-04 17:01:40]

lgtm

[commit-bot: I haz the power, 2017-01-04 18:02:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-04 18:02:01]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[haraken, 2017-01-04 23:49:30]

LGTM

https://codereview.chromium.org/2615653002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/WrapperVisitor.h (right):

https://codereview.chromium.org/2615653002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/WrapperVisitor.h:94: static void
missedWriteBarrier() {

Maybe would it be better to add NEVER_INLINE?

[Michael Lippautz, 2017-01-05 09:10:39]

https://codereview.chromium.org/2615653002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/heap/WrapperVisitor.h (right):

https://codereview.chromium.org/2615653002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/heap/WrapperVisitor.h:94: static void
missedWriteBarrier() {
On 2017/01/04 23:49:30, haraken wrote:
> 
> Maybe would it be better to add NEVER_INLINE?

Done.

[Michael Lippautz, 2017-01-05 09:10:46]

The CQ bit was checked by mlippautz@chromium.org

[Michael Lippautz, 2017-01-05 09:10:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, hlopko@chromium.org
Link to the patchset: https://codereview.chromium.org/2615653002/#ps20001
(title: "Add NEVER_INLINE")

[commit-bot: I haz the power, 2017-01-05 09:10:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-05 12:31:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1483607446056600,
"parent_rev": "3da0435e15d762ba56ab91d08f3ccd63efedbeab", "commit_rev":
"c8f2be9535cf78f61faa9e946547eb7885f87f53"}

[commit-bot: I haz the power, 2017-01-05 12:38:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-05 12:38:26]

Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.