Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: third_party/WebKit/Source/platform/heap/WrapperVisitor.h

Issue 2615653002: [wrapper-tracing] Enhance verifier output (Closed)
Patch Set: Add NEVER_INLINE Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorVerifier.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/WrapperVisitor.h
diff --git a/third_party/WebKit/Source/platform/heap/WrapperVisitor.h b/third_party/WebKit/Source/platform/heap/WrapperVisitor.h
index d93767aca69d03f9d53768f55f08a4cf38ba9a85..13de57b4c7cbaf1471f84a9feab62df200f12f56 100644
--- a/third_party/WebKit/Source/platform/heap/WrapperVisitor.h
+++ b/third_party/WebKit/Source/platform/heap/WrapperVisitor.h
@@ -91,6 +91,11 @@ class PLATFORM_EXPORT WrapperVisitor {
public:
template <typename T>
+ static NEVER_INLINE void missedWriteBarrier() {
+ NOTREACHED();
+ }
+
+ template <typename T>
void traceWrappers(const T* traceable) const {
static_assert(sizeof(T), "T must be fully defined");
static_assert(CanTraceWrappers<T>::value,
@@ -164,7 +169,8 @@ class PLATFORM_EXPORT WrapperVisitor {
template <typename T>
void markAndPushToMarkingDeque(const T* traceable) const {
if (pushToMarkingDeque(TraceTrait<T>::traceMarkedWrapper,
- TraceTrait<T>::heapObjectHeader, traceable)) {
+ TraceTrait<T>::heapObjectHeader,
+ WrapperVisitor::missedWriteBarrier<T>, traceable)) {
TraceTrait<T>::markWrapperNoTracing(this, traceable);
}
}
@@ -174,6 +180,7 @@ class PLATFORM_EXPORT WrapperVisitor {
virtual bool pushToMarkingDeque(
void (*traceWrappersCallback)(const WrapperVisitor*, const void*),
HeapObjectHeader* (*heapObjectHeaderCallback)(const void*),
+ void (*missedWriteBarrierCallback)(void),
const void*) const = 0;
};
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorVerifier.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698