Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2615643002: ui: Add debug flag for slowing down all UI animations. (Closed)

Created:
3 years, 11 months ago by reveman
Modified:
3 years, 11 months ago
CC:
asvitkine+watch_chromium.org, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, Ian Vollick
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: Add debug flag for slowing down all UI animations. This is useful when debugging ChromeOS UI performance problems. BUG=678236 TEST=chrome --ui-slow-animations Review-Url: https://codereview.chromium.org/2615643002 Cr-Commit-Position: refs/heads/master@{#442673} Committed: https://chromium.googlesource.com/chromium/src/+/6e8fc783e647eab80bde154c9783d0995d20b4ad

Patch Set 1 #

Total comments: 2

Patch Set 2 : base::MakeUnique #

Patch Set 3 : move about flag to correct place #

Patch Set 4 : add missing histograms.xml entry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/compositor.h View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/compositor/compositor.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M ui/compositor/compositor_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/compositor/compositor_switches.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
reveman
3 years, 11 months ago (2017-01-09 14:51:11 UTC) #2
danakj
LGTM https://codereview.chromium.org/2615643002/diff/1/ui/compositor/compositor.cc File ui/compositor/compositor.cc (right): https://codereview.chromium.org/2615643002/diff/1/ui/compositor/compositor.cc#newcode224 ui/compositor/compositor.cc:224: slow_animations_.reset(new ScopedAnimationDurationScaleMode( use base::MakeUnique instead of new
3 years, 11 months ago (2017-01-09 15:39:31 UTC) #3
reveman
https://codereview.chromium.org/2615643002/diff/1/ui/compositor/compositor.cc File ui/compositor/compositor.cc (right): https://codereview.chromium.org/2615643002/diff/1/ui/compositor/compositor.cc#newcode224 ui/compositor/compositor.cc:224: slow_animations_.reset(new ScopedAnimationDurationScaleMode( On 2017/01/09 at 15:39:31, danakj (slow) wrote: ...
3 years, 11 months ago (2017-01-09 22:27:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615643002/20001
3 years, 11 months ago (2017-01-09 22:28:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/190872)
3 years, 11 months ago (2017-01-09 22:45:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615643002/40001
3 years, 11 months ago (2017-01-10 03:13:03 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/299737)
3 years, 11 months ago (2017-01-10 05:01:23 UTC) #14
reveman
+asvitkine for tools/metrics/histograms/histograms.xml
3 years, 11 months ago (2017-01-10 07:01:24 UTC) #16
Alexei Svitkine (slow)
lgtm
3 years, 11 months ago (2017-01-10 15:45:20 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615643002/60001
3 years, 11 months ago (2017-01-10 18:49:45 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-10 20:26:54 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/6e8fc783e647eab80bde154c9783...

Powered by Google App Engine
This is Rietveld 408576698