Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2615633012: DevTools: Let CodeMirror handle line endings (Closed)

Created:
3 years, 11 months ago by einbinder
Modified:
3 years, 11 months ago
Reviewers:
lushnikov, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Let CodeMirror handle line endings CodeMirror takes a line seperator as an argument, so we don't have to use a regular expression. BUG=none Review-Url: https://codereview.chromium.org/2615633012 Cr-Commit-Position: refs/heads/master@{#442079} Committed: https://chromium.googlesource.com/chromium/src/+/d02e5bb7841f3dbe5247efcb1e409e30b50f44bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
einbinder
ptal
3 years, 11 months ago (2017-01-06 02:51:38 UTC) #2
pfeldman
lgtm
3 years, 11 months ago (2017-01-06 18:43:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615633012/1
3 years, 11 months ago (2017-01-06 20:48:07 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 22:42:59 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d02e5bb7841f3dbe5247efcb1e40...

Powered by Google App Engine
This is Rietveld 408576698