Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2615633011: Remove ContextClient from DOMWindowPerformance (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
sof
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ContextClient from DOMWindowPerformance Now that DOMWindowPerformance can access DOMWindow with host(), DOMWindowPerformance doesn't need to observe ContextClient. This CL removes DOMWindowPerformance::m_window. BUG=610176 Review-Url: https://codereview.chromium.org/2615633011 Cr-Commit-Position: refs/heads/master@{#441902} Committed: https://chromium.googlesource.com/chromium/src/+/21fd0270d8fcbf6f8941e1db8feeaa5cbcb97563

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M third_party/WebKit/Source/core/timing/DOMWindowPerformance.h View 3 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/timing/DOMWindowPerformance.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
haraken
PTAL
3 years, 11 months ago (2017-01-06 01:58:42 UTC) #2
sof
lgtm
3 years, 11 months ago (2017-01-06 07:42:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2615633011/1
3 years, 11 months ago (2017-01-06 07:56:08 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-06 08:01:37 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/21fd0270d8fcbf6f8941e1db8fee...

Powered by Google App Engine
This is Rietveld 408576698